From owner-svn-src-all@FreeBSD.ORG Fri Jan 7 20:02:05 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83743106566B; Fri, 7 Jan 2011 20:02:05 +0000 (UTC) (envelope-from gnn@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 733A28FC19; Fri, 7 Jan 2011 20:02:05 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p07K25Db064157; Fri, 7 Jan 2011 20:02:05 GMT (envelope-from gnn@svn.freebsd.org) Received: (from gnn@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p07K25iu064155; Fri, 7 Jan 2011 20:02:05 GMT (envelope-from gnn@svn.freebsd.org) Message-Id: <201101072002.p07K25iu064155@svn.freebsd.org> From: "George V. Neville-Neil" Date: Fri, 7 Jan 2011 20:02:05 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r217121 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2011 20:02:05 -0000 Author: gnn Date: Fri Jan 7 20:02:05 2011 New Revision: 217121 URL: http://svn.freebsd.org/changeset/base/217121 Log: Fix a memory leak in ARP queues. Pointed out by: jhb@ MFC after: 2 weeks Modified: head/sys/netinet/if_ether.c Modified: head/sys/netinet/if_ether.c ============================================================================== --- head/sys/netinet/if_ether.c Fri Jan 7 18:54:08 2011 (r217120) +++ head/sys/netinet/if_ether.c Fri Jan 7 20:02:05 2011 (r217121) @@ -736,8 +736,7 @@ match: la->la_numheld = 0; memcpy(&sa, L3_ADDR(la), sizeof(sa)); LLE_WUNLOCK(la); - for (m_hold = la->la_hold, la->la_hold = NULL; - m_hold != NULL; m_hold = m_hold_next) { + for (; m_hold != NULL; m_hold = m_hold_next) { m_hold_next = m_hold->m_nextpkt; m_hold->m_nextpkt = NULL; (*ifp->if_output)(ifp, m_hold, &sa, NULL);