From owner-svn-src-all@FreeBSD.ORG Fri Dec 10 17:06:03 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A20DF106566C; Fri, 10 Dec 2010 17:06:03 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay005.isp.belgacom.be (mailrelay005.isp.belgacom.be [195.238.6.171]) by mx1.freebsd.org (Postfix) with ESMTP id D86BA8FC0A; Fri, 10 Dec 2010 17:06:02 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAEjlAU1bseB9/2dsb2JhbACkAnm/Q4VKBA Received: from 125.224-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.224.125]) by relay.skynet.be with ESMTP; 10 Dec 2010 17:36:27 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.4/8.14.4) with ESMTP id oBAGaRkA004404; Fri, 10 Dec 2010 17:36:27 +0100 (CET) (envelope-from tijl@freebsd.org) From: Tijl Coosemans To: John Baldwin Date: Fri, 10 Dec 2010 17:36:17 +0100 User-Agent: KMail/1.13.5 (FreeBSD/8.2-PRERELEASE; KDE/4.5.2; i386; ; ) References: <201012101505.oBAF5n9X077454@svn.freebsd.org> <201012101031.36641.jhb@freebsd.org> In-Reply-To: <201012101031.36641.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1602656.uXkA9cfRbB"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit Message-Id: <201012101736.25488.tijl@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216358 - head/sys/dev/le X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2010 17:06:03 -0000 --nextPart1602656.uXkA9cfRbB Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Friday 10 December 2010 16:31:36 John Baldwin wrote: > On Friday, December 10, 2010 10:05:49 am Tijl Coosemans wrote: >> Author: tijl >> Date: Fri Dec 10 15:05:49 2010 >> New Revision: 216358 >> URL: http://svn.freebsd.org/changeset/base/216358 >>=20 >> Log: >> Use SYS_RES_IOPORT instead of PCIM_CMD_PORTEN when calling pci_enable_= io. >> =20 >> Approved by: kib (mentor) >=20 > To be honest, bus_alloc_resource() with RF_ACTIVE will set PORTEN or MEME= N for=20 > you. Drivers should no longer be calling pci_enable_io() by hand. Looking into this, in dev/sound/pci/atiixp.c and dev/sound/pci/ich.c it is used during resume. Can those calls be removed as well? And in dev/mpt/mpt.c pci_enable_io and pci_disable_io are called in a number of places. Those should probably all stay? All other cases are during device attach with bus_alloc_resource+RF_ACTIVE before or after. --nextPart1602656.uXkA9cfRbB Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iF4EABEIAAYFAk0CVwkACgkQfoCS2CCgtit9rAD/bYOGsE+x2Zg1Vfz9c/AOriT1 ELRbquSk702wVQBC0xUA/jZmQWj4Zg9YrtJAqENQEAB0iQrD+P1kP6DT7NxCZwUy =Kk3z -----END PGP SIGNATURE----- --nextPart1602656.uXkA9cfRbB--