From owner-svn-src-all@freebsd.org Tue May 8 19:12:05 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C48CFFC6B30 for ; Tue, 8 May 2018 19:12:05 +0000 (UTC) (envelope-from njm@njm.me.uk) Received: from smtp001.apm-internet.net (smtp001-out.apm-internet.net [85.119.248.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5545A7D497 for ; Tue, 8 May 2018 19:12:04 +0000 (UTC) (envelope-from njm@njm.me.uk) Received: (qmail 83616 invoked from network); 8 May 2018 19:05:21 -0000 X-APM-Authkey: 18389/1(18389/1) 2 Received: from unknown (HELO meld.njm.me.uk) (176.248.49.50) by smtp001.apm-internet.net with SMTP; 8 May 2018 19:05:21 -0000 Received: from triton.njm.me.uk (triton.njm.me.uk [192.168.144.133]) by meld.njm.me.uk (8.15.2/8.15.2) with ESMTP id w48J5K7B084884; Tue, 8 May 2018 20:05:20 +0100 (BST) (envelope-from njm@njm.me.uk) Received: from localhost (localhost [127.0.0.1]) by triton.njm.me.uk (8.15.2/8.15.2) with ESMTP id w48J5FTE012254; Tue, 8 May 2018 20:05:15 +0100 (BST) (envelope-from njm@njm.me.uk) Date: Tue, 08 May 2018 20:05:15 +0100 From: "N.J. Mann" To: Michael Tuexen , svn-src-all@freebsd.org Subject: Re: svn commit: r333382 - head/sys/netinet Message-ID: <002E38ED710A92624EB727B0@triton.njm.me.uk> In-Reply-To: <201805081848.w48Imq8b082041@repo.freebsd.org> References: <201805081848.w48Imq8b082041@repo.freebsd.org> X-Mailer: Mulberry/4.0.8 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 19:12:05 -0000 Hi, On Tuesday, May 08, 2018 18:48:52 +0000 Michael Tuexen wrote: > Author: tuexen > Date: Tue May 8 18:48:51 2018 > New Revision: 333382 > URL: https://svnweb.freebsd.org/changeset/base/333382 > > Log: > When reporting ERROR or ABORT chunks, don't use more data > that is guaranteed to be contigous. ^^^^^^^^^ contiguous [...] > Modified: head/sys/netinet/sctputil.c > ============================================================================== > --- head/sys/netinet/sctputil.c Tue May 8 18:25:37 2018 (r333381) > +++ head/sys/netinet/sctputil.c Tue May 8 18:48:51 2018 (r333382) > @@ -2660,6 +2660,13 @@ sctp_notify_assoc_change(uint16_t state, struct sctp_t > notif_len = (unsigned int)sizeof(struct sctp_assoc_change); > if (abort != NULL) { > abort_len = ntohs(abort->ch.chunk_length); > + /* > + * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to be > + * contiguos. ^^^^^^^^^ contiguous [...] > @@ -3565,6 +3572,13 @@ sctp_notify_remote_error(struct sctp_tcb *stcb, uint16 > } > if (chunk != NULL) { > chunk_len = ntohs(chunk->ch.chunk_length); > + /* > + * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to be > + * contiguos. ^^^^^^^^^ contiguous Cheers, Nick. --