From owner-cvs-src@FreeBSD.ORG Mon Apr 28 12:48:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CF3137B404 for ; Mon, 28 Apr 2003 12:48:18 -0700 (PDT) Received: from mail26a.sbc-webhosting.com (mail26a.sbc-webhosting.com [216.173.237.36]) by mx1.FreeBSD.org (Postfix) with SMTP id 9B4E443FDD for ; Mon, 28 Apr 2003 12:48:16 -0700 (PDT) (envelope-from alc@imimic.com) Received: from www.imimic.com (64.143.12.21)0268164886; Mon, 28 Apr 2003 14:34:46 -0400 (EDT) Sender: alc@FreeBSD.ORG Message-ID: <3EAD744C.981EB57B@imimic.com> Date: Mon, 28 Apr 2003 13:34:52 -0500 From: "Alan L. Cox" Organization: iMimic Networking, Inc. X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386) X-Accept-Language: en MIME-Version: 1.0 To: John Baldwin References: Content-Type: text/plain; charset=x-user-defined Content-Transfer-Encoding: 7bit X-Loop-Detect: 1 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/osf1 osf1_signal.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Apr 2003 19:48:19 -0000 John Baldwin wrote: > > On 26-Apr-2003 Alan L. Cox wrote: > > John Baldwin wrote: > >> > >> jhb 2003/04/25 12:52:30 PDT > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/alpha/osf1 osf1_signal.c > >> Log: > >> Lock Giant around calls to useracc() in osf1_sigreturn() so that the > >> function is MP safe. > >> > >> Revision Changes Path > >> 1.31 +5 -1 src/sys/alpha/osf1/osf1_signal.c > > > > The calls to useracc() should simply be eliminated because they are > > redundant. See, for example, any of the implementations of sigreturn in > > alpha/alpha/machdep.c. > > I don't mind if they are removed. :) > Is that a subtle suggestion for me to do it? :-) Alan