From owner-svn-src-user@FreeBSD.ORG Tue Mar 12 12:06:55 2013 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 4C26C697; Tue, 12 Mar 2013 12:06:55 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ia0-x22a.google.com (mail-ia0-x22a.google.com [IPv6:2607:f8b0:4001:c02::22a]) by mx1.freebsd.org (Postfix) with ESMTP id 10318C3; Tue, 12 Mar 2013 12:06:55 +0000 (UTC) Received: by mail-ia0-f170.google.com with SMTP id h8so4773243iaa.15 for ; Tue, 12 Mar 2013 05:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=2EhYffxBacGWO/veC+/ZoB5NF1AOxVO0SzGKM5fRNV0=; b=KiFksea3/jKagf7n1DajWzt57AxJNoQyOjCH4ix93xMP7woURBvZjaCfkCikjCd9/L 78/ztmRCtgI6JpKXQqWeOBe88AgVtT8E8qimybYILwyAasOBiFN9dCRo5Zq1EMNHGM22 kJuYtyHYC83FqNe15q+57puHDxdK5mcI8QmT8sGpzfvFBJ3Z1psONQhzDGJTkfogrz1H NfMAH0oxOJi0h0t94KJ0bIqo51CwCZUhrDQGY1H7nVMhPKISMx3hbm9g2DBzL+mkC9Xi 6ZA9sjYNZBzAw/v88F61nLuOWLBBqBeu7EFbiP9sHR5e9AcrXl8aoZt+Qa2rxeo0NNga WwjA== MIME-Version: 1.0 X-Received: by 10.50.140.67 with SMTP id re3mr11109839igb.100.1363090014653; Tue, 12 Mar 2013 05:06:54 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.42.117.134 with HTTP; Tue, 12 Mar 2013 05:06:54 -0700 (PDT) In-Reply-To: References: <201303120614.r2C6EWve058965@svn.freebsd.org> Date: Tue, 12 Mar 2013 13:06:54 +0100 X-Google-Sender-Auth: EvpvoiYffOoUURzsgiwMNEpsvvs Message-ID: Subject: Re: svn commit: r248185 - user/attilio/vmcontention/sys/vm From: Attilio Rao To: Alan Cox Content-Type: text/plain; charset=UTF-8 Cc: src-committers@freebsd.org, svn-src-user@freebsd.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2013 12:06:55 -0000 On Tue, Mar 12, 2013 at 1:04 PM, Attilio Rao wrote: > On Tue, Mar 12, 2013 at 7:14 AM, Alan Cox wrote: >> Author: alc >> Date: Tue Mar 12 06:14:31 2013 >> New Revision: 248185 >> URL: http://svnweb.freebsd.org/changeset/base/248185 >> >> Log: >> When transferring the page from one object to another, don't insert the >> page into its new object until the page's pindex has been updated. >> Otherwise, one code path within vm_radix_insert() may use the wrong >> pindex value. > > This is just a style change really because the code already subtracts > offindxstart from current m->pindex when inserting. The pindex on the > page is then adjusted when the real subtraction happens. > IIRC, I did this way because of less diffs against -CURRENT, but the > code looks correct to me already in the older version. Also, I would reduce at minimum the functional changes that could just introduce bugs against a well-tested implementation. Attilio -- Peace can only be achieved by understanding - A. Einstein