From owner-cvs-all Wed Jul 10 16:46:22 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D73A937B401; Wed, 10 Jul 2002 16:46:16 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA3BD43E5E; Wed, 10 Jul 2002 16:46:15 -0700 (PDT) (envelope-from peter@wemm.org) Received: from fw.wemm.org (canning.wemm.org [192.203.228.65]) by canning.wemm.org (Postfix) with ESMTP id 6CAD52A7EA; Wed, 10 Jul 2002 16:46:15 -0700 (PDT) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by fw.wemm.org (Postfix) with ESMTP id EB37A4C283; Wed, 10 Jul 2002 16:46:14 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 61E5E3808; Wed, 10 Jul 2002 16:46:15 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Matthew Dillon Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/chmod chmod.c In-Reply-To: <200207102316.g6ANGOGx076244@apollo.backplane.com> Date: Wed, 10 Jul 2002 16:46:15 -0700 From: Peter Wemm Message-Id: <20020710234615.61E5E3808@overcee.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Matthew Dillon wrote: > I suppose the minimal fix is to remove __printf0like from err(), > errx(), and warn() in /usr/src/include/err.h. So that is what I will > do if this problem isn't fixed in the tree by 9:00 p.m. PDT tonight. No, the correct minimal fix is to stub out the attributes, that's why we have fine granularity on them! eg: --- cdefs.h 2002/07/08 16:43:35 1.56 +++ cdefs.h 2002/07/10 23:18:10 @@ -174,9 +174,9 @@ __attribute__((__format__ (__scanf__, fmtarg, firstvararg))) #endif /* Compiler-dependent macros that rely on FreeBSD-specific extensions. */ -#if __FreeBSD_cc_version >= 300001 +#if __FreeBSD_cc_version >= 300001 && !defined(__sparc64__) #define __printf0like(fmtarg, firstvararg) \ __attribute__((__format__ (__printf0__, fmtarg, firstvararg))) #else #define __printf0like(fmtarg, firstvararg) The sparc64 thing just was an example. It may need this instead: #if __FreeBSD_cc_version >= 300001 && __FreeBSD_cc_version < 500003 There, problem solved. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message