From nobody Thu Jun 12 03:05:05 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bHnT56XRZz5xy4Q for ; Thu, 12 Jun 2025 03:05:13 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bHnT53LZ1z3sPd for ; Thu, 12 Jun 2025 03:05:08 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-451e2f0d9c2so3364235e9.1 for ; Wed, 11 Jun 2025 20:05:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749697507; x=1750302307; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KlYn7TpvpUXL4FGxihQJIYoM/Xx0FFT578Pno3uRIyk=; b=jp83Q5LHz1Ii9i4PmPD2MQ4PEJgf0N/FyF2JNMAciVNTmweQ5Aye6aXVVpxmLmnjBC snryeOWuQGS5WLtAp5m6Sw5eZBK6hSzQh59agtuVzUh//rAXypXKZzPHwCIarhVchzSX 8RnNWl7bWORrLfHVT6W1jFE2qE6sa4jM7bgpIY/ThyY5BYFJobfpD4XcwIq2ZPoAPeV6 BPhPUj9Jg+7BC/ZHA/GYdCsupgZNlM7XiwUX8PmeRC8xxBgZNVqbSjg4vvwWF6WAtFW5 Rvbh03CMuKs92iGJGTR13DNaAl3XITzTGP/NXBbj5Uf1rj8uilRgmv5Ar/HHvgod4/nt 2k8g== X-Forwarded-Encrypted: i=1; AJvYcCUmf4iejckfWV82dEJsxmmrF1WB6BsEgNdG3hdx+teZ6FBWe+U438exmpjUCUhmgDxBGidL9xqgFmuytnQ7FIf5afWz@freebsd.org X-Gm-Message-State: AOJu0Yz80zgwMoEeuAHZFOS+XUKh3Zw+gQTJpcC7Q1Z3xrW1iH7Y31lj XI6QUqSxadl6MEKaSV9/dNZoir1ObOGRRN6V2FunsZFmmKUhlb6J9FKHF79oL4af3GI= X-Gm-Gg: ASbGnctD5In+bTxZIDYYu6DfjJiaaoEHJbXK/AOXi/QzINPm/LlWialKH4FGUGnwPCt oIH6q/QnQCsYZKgQ+ZjxSzROjhI42Q5NOYtutePu/TlkTPxhUY1JzrmE37yq+fBA/3cON/9cJi2 C7EuZZGjaSVlrAKqW4bNNiIiw90l4PZYXFAFG+ia4Y8ep95s3VPc0Fm2GSaWZMWpzWy4A39HTIl JHHwRF400Qik8k2cGDSAaPhfbzuJKk1WntGk94FWWFIuMWsFln6GKBSMjUolvKe++psGmH9cLrq QVLgJ/J5ljz0aqQroL9mALeHg7GXwKz3Np5If+dFt5K3FooGOTg8X5GbrGSgxmCct/qcZebtCwe z X-Google-Smtp-Source: AGHT+IG0D+mJG14K/TlskcmW5Mq3zm1jPSntDTVVq63AOvmHO7otvD8xr81XueEcv2RCOf1WCNJ4Yw== X-Received: by 2002:a05:600c:4f0f:b0:453:10c1:cb21 with SMTP id 5b1f17b1804b1-4532c28ca76mr14237475e9.8.1749697506161; Wed, 11 Jun 2025 20:05:06 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320580af6sm52833435e9.1.2025.06.11.20.05.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jun 2025 20:05:05 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: git: 3d12567133bf - main - Add the POSIX sig2str(3) & str2sig(3) calls From: Jessica Clarke In-Reply-To: Date: Thu, 12 Jun 2025 04:05:05 +0100 Cc: Shawn Webb , Warner Losh , Ricardo Branco , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <86507548-1B8C-4CD1-BB18-C884D38EA489@freebsd.org> References: <202506112316.55BNGeGh046207@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Rspamd-Queue-Id: 4bHnT53LZ1z3sPd X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On 12 Jun 2025, at 03:59, Warner Losh wrote: >=20 > On Wed, Jun 11, 2025 at 10:56=E2=80=AFPM Shawn Webb = wrote: >>=20 >> On Wed, Jun 11, 2025 at 11:16:40PM +0000, Warner Losh wrote: >>> The branch main has been updated by imp: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D3d12567133bfb4082a5115f16a71a865= ff2af7fb >>>=20 >>> commit 3d12567133bfb4082a5115f16a71a865ff2af7fb >>> Author: Ricardo Branco >>> AuthorDate: 2025-05-10 20:56:03 +0000 >>> Commit: Warner Losh >>> CommitDate: 2025-06-11 23:16:22 +0000 >>>=20 >>> Add the POSIX sig2str(3) & str2sig(3) calls >>>=20 >>> Signed-off-by: Ricardo Branco >>> Reviewed by: imp, kib, des, jilles >>> Pull Request: https://github.com/freebsd/freebsd-src/pull/1696 >>> --- >>> include/signal.h | 9 ++++ >>> lib/libc/gen/Makefile.inc | 3 ++ >>> lib/libc/gen/Symbol.map | 2 + >>> lib/libc/gen/psignal.3 | 56 ++++++++++++++++++++++- >>> lib/libc/gen/sig2str.c | 112 = ++++++++++++++++++++++++++++++++++++++++++++++ >>> 5 files changed, 180 insertions(+), 2 deletions(-) >>>=20 >>> diff --git a/include/signal.h b/include/signal.h >>> index c1d341f317f4..22fefb63568f 100644 >>> --- a/include/signal.h >>> +++ b/include/signal.h >>> @@ -40,6 +40,10 @@ >>> #include >>> #endif >>>=20 >>> +#if __POSIX_VISIBLE >=3D 202405 || __BSD_VISIBLE >>> +#define SIG2STR_MAX 32 /* size of buffer required for = sig2str() */ >>> +#endif >>=20 >> Hey Warner and Ricardo, >>=20 >> The above breaks building world when _FORTIFY_SOURCE=3D2. I've = committed >> in HardenedBSD a fix: >> = https://git.hardenedbsd.org/hardenedbsd/HardenedBSD/-/commit/0572db282c5a5= 42fe0de52739932e91eade537ed >>=20 >> I suppose that the !defined gate might not actually be desired, since >> doing it the way I did might cause issues if third-party code defines >> the macro to a value smaller than what libc was built with. I might >> remove that gate. >=20 > I don't think we need the !defined part of it... >=20 > But what software is breaking? What's the error message? Maybe the > fact it's undefined is pointing at a different bug=E2=80=A6 Probably include/ssp/signal.h unconditionally defining the wrapper? Presumably gating that with the same condition as sig2str itself would fix things properly rather than such bogus hacks. But yes, including the actual error message when reporting a build failure would have been helpful. Jess