From nobody Fri Feb 6 17:56:07 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f71x000F3z6RVnb for ; Fri, 06 Feb 2026 17:56:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f71wz3s8vz4K4B for ; Fri, 06 Feb 2026 17:56:19 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-8c531473fdcso133369785a.3 for ; Fri, 06 Feb 2026 09:56:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1770400579; cv=none; d=google.com; s=arc-20240605; b=k8sZ5xIO12qpC3KR7svyoAPn3D+Ojy1CmS5Ep1IpNnFXyguaMZ3wyTkyaHmoIrSCiX 5FNbpoAi20MLnkqHlZ9G6qFzgKMelf1J2x1wIqwg2nXzzo/FQMq9vJ4IHOdafLJamvsP GAHslOOWBhBLhUFDRK9sUkARXMQ553U+qlngjWlERgj7IMmWPEw5W0guxx081zDmS3E6 BWhd35QmxlMw5wtA7rz8PQDoL7+n/LtJCefSqtcqyw670VuUyFHLt4cVIanesqXzTLE1 Q03xOBj1UmFp85HfpJeyw+RGAjsCdKMJrY5CtBuW9E0b6O3RO4sZqhYJvKPfaMjdPyQn yqkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=cQ4qTzV/0YDEIwCIGfsx2A4Xn+eCfp171+P6YjD9E6k=; fh=9znFQ5yEMk04U8skGTeUseK4va6vrzvq/T5PnZ2Bqb8=; b=fSsy/Oyo30PyZ7kykM3XBwF+PEmfOBbFPBkggHE/fx9lGHswjgl4hjQavJ7sCIK5B5 rUmxi6YD6W4VDt6cnsi6jM/3KwYBscC0H40hRUHoC7OZbOA7VaQV17UPU851myaIPkk8 L7FAsfXYL2Qp7BJTip12fOK4LX6CV3vTr7AWJMnYj6akUEBu+ktUIp+J7jpjHo5mYxmb 2UfkefLBIEdnareug7iuJblBXrC3WXXTavCX6VxH+xo5OMMR3HsskNP/eDvcBZ83At4C GvcZYHcOiRsD2DnUBvLeSWtr6Nt72HMSLh0YpCgreUh0Gv8CehosxCu4sVxCcKpgKGi2 ARng==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770400579; x=1771005379; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cQ4qTzV/0YDEIwCIGfsx2A4Xn+eCfp171+P6YjD9E6k=; b=JYARVC8P7q314AQ3Anh0ZPMtJyd8VEvVkNMhzICWbEtgBwenSE7cZs+efbv5kY3P0b /HLMqbH668j0yBIR1yX220WLLPHAhJReaWRYEaRDVvcEGxGV1MYOOFlUzYixdPCe7Kmw Hwb6gJX965I2PIBykeIwz2aYwJBJlSMzQwLWOGK02eWY/xK9k4bHcZIlWeLcptYzWuqN gs81YYVT/CTFFVOQkKG1PleF8aAEp9Eu9LJcoh3uplOyKU7UcNm2+fWnRfmZdPB4pbh8 bXoMKftpqx/QlaRdnp68iN2WkB+4oyVXxvb3AoOdpNqIcqIpBwjCd4ZswIGji8LSZme8 hIlw== X-Forwarded-Encrypted: i=1; AJvYcCUEJnbPBROWrB0/jlR7Z2wKYkwL6e2N71vYTSqieXB3m2RhUVZncGer2zbY0h/2WEotaBCXbOyDpTEkRhMDuqXSlGGi8g==@freebsd.org X-Gm-Message-State: AOJu0Yx8TtQKbHT6hCqxsO9W839Z0ZgMX4rh8G1ZlwNWDtKbYiZv7dJC QoeFg1BthrUgjOwck+TCl153oJnyI8hRPNQ08UxAWbgabTpTdC8I/EJ/oEgJYWn2pH6aKVz3oYy 0zDg3Cf/bUVlFW8QiMU+RbQnH4PTLH7c= X-Gm-Gg: AZuq6aJfhNE6CbnBvLWf5s0tfPfwVAJ7AUc2INCRcrmH44yULMsOJ20Xo/LmlzD2xUb QcACH+ucPj51gv68JRukIeBjO8LlYnG+klhQ/edmUxpAwX926HIlqYnA6YdImEHxnvcJcZQ4v0o gVL0EQ8KZX62rDkgMZnj13/96gi+z/dEBG0vu8tbX9QIPnf6RLQbSY8rMqv4bfNz1wYtYR/Kw+A tH1Grey1sYrevJ+/pZJ+S+NZ5+E26Ko8HHgSrrcYtuG7NFdUY9o1yoAWyBK2oQy4Aa/XlmLCdpw brjw/nuXqIK6MHzNIwbBXEkNF6EpNw== X-Received: by 2002:a05:620a:40c5:b0:8b2:eea5:3311 with SMTP id af79cd13be357-8caef7e1788mr491246985a.26.1770400578619; Fri, 06 Feb 2026 09:56:18 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <695f8abf.30bec.62a9009@gitrepo.freebsd.org> <11fddfa0-41fd-430a-8ecb-8afa27385878@FreeBSD.org> In-Reply-To: <11fddfa0-41fd-430a-8ecb-8afa27385878@FreeBSD.org> From: Adrian Chadd Date: Fri, 6 Feb 2026 09:56:07 -0800 X-Gm-Features: AZwV_QgVm5nVhz_gsTjtCvj4bSNcUxyyJGSan7L3GXkph1gbjD2pnfQxAxqAkz0 Message-ID: Subject: Re: git: c0df8f6f0e6a - main - acpi: Make taskqueue only run on BSP To: Kyle Evans Cc: Aymeric Wibo , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4f71wz3s8vz4K4B X-Spamd-Bar: ---- oh, is this what's causing it? i've been seeing weird behaviour on my intel based MSI GE76 raider that aligns with this. Do we actually know that the BSP is always the CPU that woke up from ACPI? -adrian On Fri, 6 Feb 2026 at 07:59, Kyle Evans wrote: > > On 1/8/26 04:45, Aymeric Wibo wrote: > > The branch main has been updated by obiwac: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc0df8f6f0e6a5f77ec9140e8= 075d09c55fe4c3c7 > > > > commit c0df8f6f0e6a5f77ec9140e8075d09c55fe4c3c7 > > Author: Aymeric Wibo > > AuthorDate: 2025-12-29 20:01:50 +0000 > > Commit: Aymeric Wibo > > CommitDate: 2026-01-08 10:35:54 +0000 > > > > acpi: Make taskqueue only run on BSP > > > > This is needed because when we add the suspend-to-idle loop, we on= ly > > want to break the BSP out of idle to process the taskqueue while k= eeping > > all the others idled. > > > > Currently assuming BSP to be CPU0, which may not always be the cas= e on > > non-x86. > > > > Reviewed by: kib > > Approved by: kib > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D54406 > > --- > > sys/dev/acpica/Osd/OsdSchedule.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/sys/dev/acpica/Osd/OsdSchedule.c b/sys/dev/acpica/Osd/OsdS= chedule.c > > index f0464709e8ad..0c5eadb87687 100644 > > --- a/sys/dev/acpica/Osd/OsdSchedule.c > > +++ b/sys/dev/acpica/Osd/OsdSchedule.c > > @@ -35,6 +35,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -109,10 +110,13 @@ static void > > acpi_taskq_init(void *arg) > > { > > int i; > > + /* XXX Currently assuming BSP is CPU0. */ > > + cpuset_t just_bsp =3D CPUSET_T_INITIALIZER(0x1); > > > > acpi_taskq =3D taskqueue_create_fast("acpi_task", M_NOWAIT, > > &taskqueue_thread_enqueue, &acpi_taskq); > > - taskqueue_start_threads(&acpi_taskq, acpi_max_threads, PWAIT, "acp= i_task"); > > + taskqueue_start_threads_cpuset(&acpi_taskq, acpi_max_threads, PWAI= T, > > + &just_bsp, "acpi_task"); > > if (acpi_task_count > 0) { > > if (bootverbose) > > printf("AcpiOsExecute: enqueue %d pending tasks\n", > > > > Hi, > > Mentioned privately, but also bringing it to the list in case anyone else= has had the same symptom- updating my frame.work laptop from ~December mai= n to ~February main resulted in a power-button wakeup shutting down the sys= tem after it wakes up. The result of a bisect pointed at this commit relia= bly causing it, and reverting it locally does seem to fix it. > > Thanks, > > Kyle Evans >