Date: Wed, 31 May 2006 05:21:18 +1000 From: Peter Jeremy <peterjeremy@optushome.com.au> To: Andrey Chernov <ache@freebsd.org>, Craig Rodrigues <rodrigc@crodrigues.org>, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c Message-ID: <20060530192118.GB723@turion.vk2pj.dyndns.org> In-Reply-To: <20060530041210.GA48857@nagual.pp.ru> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> <20060530041210.GA48857@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2006-May-30 08:12:10 +0400, Andrey Chernov wrote:
>On Mon, May 29, 2006 at 11:45:31PM -0400, Craig Rodrigues wrote:
>
>> + if (strcmp(argv[i], "ro") == 0 &&
>> + strcmp(argv[i-1], "-o") == 0) {
>> + return 1;
>
>It looks like hack. There is comma separated list for -o needs to be fully
>parsed, f.e. '-o acls,ro'
There's already code in mount(8) that understands how to merge conflicting
option lists (from the command line and fstab). It needs to be taught
that:
- -r, ro and norw are equivalent
- rw and noro are equivalent
- -r/ro/norw and rw/noro are complementary.
--
Peter Jeremy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060530192118.GB723>