From owner-freebsd-net@freebsd.org Thu Apr 6 12:57:28 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E983ED2F0F9 for ; Thu, 6 Apr 2017 12:57:28 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward1h.cmail.yandex.net (forward1h.cmail.yandex.net [IPv6:2a02:6b8:0:f35::11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 617F2630 for ; Thu, 6 Apr 2017 12:57:28 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from smtp1o.mail.yandex.net (smtp1o.mail.yandex.net [37.140.190.26]) by forward1h.cmail.yandex.net (Yandex) with ESMTP id A87492141B; Thu, 6 Apr 2017 15:57:15 +0300 (MSK) Received: from smtp1o.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp1o.mail.yandex.net (Yandex) with ESMTP id 669081300ACA; Thu, 6 Apr 2017 15:57:13 +0300 (MSK) Received: by smtp1o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id FwvpPivhaa-vDhqjZZo; Thu, 06 Apr 2017 15:57:13 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1491483433; bh=EbqYHN+5KYzRhu6T0SCGBgD8t8itUxVWvGbSGXSLkWI=; h=Subject:To:References:From:Message-ID:Date:In-Reply-To; b=rKKRoF7diDQsGh/1LIuNM+e2iGTd/kHAeUxc+zC+4/xSz+bJgrb4V7e16pbnVFa4K ptfpkulnpMaeJifpT753f2o55ypKnAYAxzBVXBA6rqeRreNAjBxiPvTD39Apiqnrtl Be3Zv6d0o2lb+0cCjcD6A4JrLKtSrFfrrINpdAoE= Authentication-Results: smtp1o.mail.yandex.net; dkim=pass header.i=@yandex.ru X-Yandex-Suid-Status: 1 0,1 0 Subject: Re: if_igb(4) VLAN(4) and [RT]XCSUM_IPV6, TSO6 To: Harry Schmalzbauer , "freebsd-net@freebsd.org" References: <58CAD8CB.3060101@omnilan.de> From: "Andrey V. Elsukov" Openpgp: id=E6591E1B41DA1516F0C9BC0001C5EA0410C8A17A Message-ID: <283742a4-5314-eef3-ed53-958a1f6e7492@yandex.ru> Date: Thu, 6 Apr 2017 15:56:23 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <58CAD8CB.3060101@omnilan.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BR7AR0JLbRfuqWuWM4JT0A3Sx059frpVE" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 12:57:29 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BR7AR0JLbRfuqWuWM4JT0A3Sx059frpVE Content-Type: multipart/mixed; boundary="dmrqfmKFNXU8ineQAOLl1U52WvF8SFGdc"; protected-headers="v1" From: "Andrey V. Elsukov" To: Harry Schmalzbauer , "freebsd-net@freebsd.org" Message-ID: <283742a4-5314-eef3-ed53-958a1f6e7492@yandex.ru> Subject: Re: if_igb(4) VLAN(4) and [RT]XCSUM_IPV6, TSO6 References: <58CAD8CB.3060101@omnilan.de> In-Reply-To: <58CAD8CB.3060101@omnilan.de> --dmrqfmKFNXU8ineQAOLl1U52WvF8SFGdc Content-Type: multipart/mixed; boundary="------------C67742D2F01C02EE26440D29" Content-Language: en-US This is a multi-part message in MIME format. --------------C67742D2F01C02EE26440D29 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16.03.2017 21:26, Harry Schmalzbauer wrote: > Hello, >=20 > I'm wondering if I really loose [RT]XCSUM_IPV6 on if_igb(4) vlan(4) > children. > My igb0 (Kawela, aka 82576) options end with > "TSO6,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6" >=20 > The vlan(4) filtered interfaces show these: > options=3D303 >=20 > So TSO6 is inherited, but RC/TXCSUM_IPV6 dropped? Can you test the attached patch? --=20 WBR, Andrey V. Elsukov --------------C67742D2F01C02EE26440D29 Content-Type: text/x-patch; name="vlan.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="vlan.diff" Index: sys/net/if_vlan.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/net/if_vlan.c (revision 316506) +++ sys/net/if_vlan.c (working copy) @@ -1555,13 +1555,16 @@ vlan_capabilities(struct ifvlan *ifv) * offloading requires hardware VLAN tagging. */ if (p->if_capabilities & IFCAP_VLAN_HWCSUM) - ifp->if_capabilities =3D p->if_capabilities & IFCAP_HWCSUM; + ifp->if_capabilities =3D + p->if_capabilities & (IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6); =20 if (p->if_capenable & IFCAP_VLAN_HWCSUM && p->if_capenable & IFCAP_VLAN_HWTAGGING) { - ifp->if_capenable =3D p->if_capenable & IFCAP_HWCSUM; + ifp->if_capenable =3D + p->if_capenable & (IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6); ifp->if_hwassist =3D p->if_hwassist & (CSUM_IP | CSUM_TCP | - CSUM_UDP | CSUM_SCTP); + CSUM_UDP | CSUM_SCTP | CSUM_TCP_IPV6 | CSUM_UDP_IPV6 | + CSUM_SCTP_IPV6); } else { ifp->if_capenable =3D 0; ifp->if_hwassist =3D 0; --------------C67742D2F01C02EE26440D29-- --dmrqfmKFNXU8ineQAOLl1U52WvF8SFGdc-- --BR7AR0JLbRfuqWuWM4JT0A3Sx059frpVE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAljmOvcACgkQAcXqBBDI oXrvYgf/XW+rL29lJ4fYw/QmZ5dW/OJIcDB3j5Bj/nNr3gC23sI4UG7HSuGe3XJG pkzvpC6I5YZJfkff6oIAlbE8CcOOMHU+twUEoXJPaQusBbDXe/gA5ljVNAds/uW8 sJJNs2Wsp4gZwq2sE32QtfcVw5qmb95Ca5ssnZz+qoujKRWfQH+YMiNAoB5y9dMq zIjkbGBkYayOwBpdt80ZMp2DyIU1CMjzsHECMk2POVUYH/rcaIweIG7juCBPIfOl MT6iUCgee6fuI7NJ30ALaw9TaAoGK+RptnPyK9z453wKJDJ8sbmsBYPH0+pbb083 cBbr1ebn7Fv0jf6FOmJENiDXzSOuJw== =0za7 -----END PGP SIGNATURE----- --BR7AR0JLbRfuqWuWM4JT0A3Sx059frpVE--