Date: Thu, 6 Apr 2017 15:56:23 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Harry Schmalzbauer <freebsd@omnilan.de>, "freebsd-net@freebsd.org" <freebsd-net@FreeBSD.org> Subject: Re: if_igb(4) VLAN(4) and [RT]XCSUM_IPV6, TSO6 Message-ID: <283742a4-5314-eef3-ed53-958a1f6e7492@yandex.ru> In-Reply-To: <58CAD8CB.3060101@omnilan.de> References: <58CAD8CB.3060101@omnilan.de>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--BR7AR0JLbRfuqWuWM4JT0A3Sx059frpVE
Content-Type: multipart/mixed; boundary="dmrqfmKFNXU8ineQAOLl1U52WvF8SFGdc";
protected-headers="v1"
From: "Andrey V. Elsukov" <bu7cher@yandex.ru>
To: Harry Schmalzbauer <freebsd@omnilan.de>,
"freebsd-net@freebsd.org" <freebsd-net@FreeBSD.org>
Message-ID: <283742a4-5314-eef3-ed53-958a1f6e7492@yandex.ru>
Subject: Re: if_igb(4) VLAN(4) and [RT]XCSUM_IPV6, TSO6
References: <58CAD8CB.3060101@omnilan.de>
In-Reply-To: <58CAD8CB.3060101@omnilan.de>
--dmrqfmKFNXU8ineQAOLl1U52WvF8SFGdc
Content-Type: multipart/mixed;
boundary="------------C67742D2F01C02EE26440D29"
Content-Language: en-US
This is a multi-part message in MIME format.
--------------C67742D2F01C02EE26440D29
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
On 16.03.2017 21:26, Harry Schmalzbauer wrote:
> Hello,
>=20
> I'm wondering if I really loose [RT]XCSUM_IPV6 on if_igb(4) vlan(4)
> children.
> My igb0 (Kawela, aka 82576) options end with
> "TSO6,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6"
>=20
> The vlan(4) filtered interfaces show these:
> options=3D303<RXCSUM,TXCSUM,TSO4,TSO6>
>=20
> So TSO6 is inherited, but RC/TXCSUM_IPV6 dropped?
Can you test the attached patch?
--=20
WBR, Andrey V. Elsukov
--------------C67742D2F01C02EE26440D29
Content-Type: text/x-patch;
name="vlan.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="vlan.diff"
Index: sys/net/if_vlan.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/net/if_vlan.c (revision 316506)
+++ sys/net/if_vlan.c (working copy)
@@ -1555,13 +1555,16 @@ vlan_capabilities(struct ifvlan *ifv)
* offloading requires hardware VLAN tagging.
*/
if (p->if_capabilities & IFCAP_VLAN_HWCSUM)
- ifp->if_capabilities =3D p->if_capabilities & IFCAP_HWCSUM;
+ ifp->if_capabilities =3D
+ p->if_capabilities & (IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6);
=20
if (p->if_capenable & IFCAP_VLAN_HWCSUM &&
p->if_capenable & IFCAP_VLAN_HWTAGGING) {
- ifp->if_capenable =3D p->if_capenable & IFCAP_HWCSUM;
+ ifp->if_capenable =3D
+ p->if_capenable & (IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6);
ifp->if_hwassist =3D p->if_hwassist & (CSUM_IP | CSUM_TCP |
- CSUM_UDP | CSUM_SCTP);
+ CSUM_UDP | CSUM_SCTP | CSUM_TCP_IPV6 | CSUM_UDP_IPV6 |
+ CSUM_SCTP_IPV6);
} else {
ifp->if_capenable =3D 0;
ifp->if_hwassist =3D 0;
--------------C67742D2F01C02EE26440D29--
--dmrqfmKFNXU8ineQAOLl1U52WvF8SFGdc--
--BR7AR0JLbRfuqWuWM4JT0A3Sx059frpVE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAljmOvcACgkQAcXqBBDI
oXrvYgf/XW+rL29lJ4fYw/QmZ5dW/OJIcDB3j5Bj/nNr3gC23sI4UG7HSuGe3XJG
pkzvpC6I5YZJfkff6oIAlbE8CcOOMHU+twUEoXJPaQusBbDXe/gA5ljVNAds/uW8
sJJNs2Wsp4gZwq2sE32QtfcVw5qmb95Ca5ssnZz+qoujKRWfQH+YMiNAoB5y9dMq
zIjkbGBkYayOwBpdt80ZMp2DyIU1CMjzsHECMk2POVUYH/rcaIweIG7juCBPIfOl
MT6iUCgee6fuI7NJ30ALaw9TaAoGK+RptnPyK9z453wKJDJ8sbmsBYPH0+pbb083
cBbr1ebn7Fv0jf6FOmJENiDXzSOuJw==
=0za7
-----END PGP SIGNATURE-----
--BR7AR0JLbRfuqWuWM4JT0A3Sx059frpVE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?283742a4-5314-eef3-ed53-958a1f6e7492>