From nobody Fri Nov 21 21:36:40 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dCpSn1w38z6Hp1d for ; Fri, 21 Nov 2025 21:36:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dCpSn0kFqz40VX for ; Fri, 21 Nov 2025 21:36:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763761001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nv8b8itEGcfBPr/IMtZVyv4DODA2V8eLf9+T8K58CNc=; b=iS7auORvCd/mFniaFC2dUaU34eUl472ySSqg6OfXRmnnDsj/wKX8TBJIf6v0udCZcMy3Z0 kUFNvUGOmzFM9Vv6jWDTAoADxIhj0xBF/yIrpo280m2EBLV8yWfS7o03JUlO7y4fbR7All pxEn6w0osJGER7Jv5I1HJC9WjZFoj9JRsQPBrxBPPyF7tt2oVcIYlhZ/2kqg70ghFtSvQl 1GcM5xkaSJSXvbS5DUo2NcoVSIWnOCyvcPZLLQ5IOywoesxzcMs9R1w4krJ4hpm58HZ3X4 DCaVl2gcBwKOFg3PC+z0FcjQYXR1tooklEdTEdnXcRNQB2onNcs1B5lsPJsFVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763761001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nv8b8itEGcfBPr/IMtZVyv4DODA2V8eLf9+T8K58CNc=; b=icQJkxfs01H+4fGBo0R7NBk/mfJATR/2X7iK4wXszd0zFNC+KbO5h0eqQiU95wTjvTbWMy vBGZujjmIfZ8voMsthLuGy6pLV6oiA9YvigFN8ksPOBFSwA1mo23+oJoaMVlBCHA7lJhC8 FAtaXxW3Fii6+YGOg77tCbL4DThIt58au3DcvDb/qFyeSappJZx6kmGuNNSOYoQo57djVj c2RsTEKkIyOE6iR+IMch23AY3AgB1I35+DEx9x6q2QRPnXzInSG/9lYkPKViMHXIOZK+U6 xPqWxszFK4ZMcXs5jg3EpFWJDm1NZRq6ACiymzHkc7Dg5rIllCn6uFSff2Dslg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763761001; a=rsa-sha256; cv=none; b=HSL7161bOjQN1rchfy8paxvVsm1YwnRGZulT+6AUVeB9a2iFnv17k7ZWJ4/hzLNpnQKSSK 9U5J/8bo2qhuI3ITaqdzHbXg9870XmTTUtdrD87VGK/FqDVssutioi++wXskMsGY6BS65L wqeJNNDb5dXb0bpukh4KY1avJL7T4XFBIYhO4BoM4YPfPSFBxYiAY95QW06PtrrCqcpUHX fpWL2DO35dcdaFlfVBM0JHhORFUjuGYKsC2aQn8iKo6G4Skylxye7ptoP+eMNmemyLN7Lm eMT/AciILxYe3EE3KuNjoYHCbLvWh6PtKLGkjg6dsXyBFUdCkzBlyJJnkTWPyA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4dCpSn00K4zTZD for ; Fri, 21 Nov 2025 21:36:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 5ALLaeQq033735 for ; Fri, 21 Nov 2025 21:36:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 5ALLaeVA033734 for net@FreeBSD.org; Fri, 21 Nov 2025 21:36:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 256579] arp(8) -S doesn't honour "blackhole" keyword Date: Fri, 21 Nov 2025 21:36:40 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: zarychtam@plan-b.pwste.edu.pl X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: melifaro@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256579 --- Comment #4 from Marek Zarychta --- Created attachment 265565 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D265565&action= =3Dedit 0001-arp-bring-back-reject-discard-functionalify-for-arp-.patch Today, I retested the patch from https://reviews.freebsd.org/D32240, and it appears to work correctly on stable/15. The original patch, rebased on the recent HEAD, is uploaded here. I had to introduce only a small change in the section below. To make it consistent with the recent version of the file sys/net/if_llatbl.c "lltable_free_entry(llt, lle);" was added before "return (EINVAL);". + if (!discard) { + if (!fill_lladdr(ifp, dst->sa_family, lle, LLADDR(dl))) { + lltable_free_entry(llt, lle); + return (EINVAL); + } + } else { + if (rtm->rtm_flags & RTF_REJECT) + lle->la_flags |=3D LLE_REJECT; + else + lle->la_flags |=3D LLE_DISCARD; + if (rtm->rtm_rmx.rmx_expire =3D=3D 0) + lle->la_flags |=3D LLE_STATIC; + } Please refresh this review and commit this code if still applicable. --=20 You are receiving this mail because: You are on the CC list for the bug.=