From owner-freebsd-arch@freebsd.org Thu Dec 3 19:53:14 2015 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37E89A4076E for ; Thu, 3 Dec 2015 19:53:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-x231.google.com (mail-qg0-x231.google.com [IPv6:2607:f8b0:400d:c04::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DCAC91302 for ; Thu, 3 Dec 2015 19:53:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qgeb1 with SMTP id b1so70741315qge.1 for ; Thu, 03 Dec 2015 11:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=2yGgsK0xacoBajJU0rwl6zKhrhZfywqOM9uEa4as70c=; b=VhY157tpUTs3vlSqawyBD9S5x0IZ5iwNYlVwaKAbe6P+MNCSjCpcjoEBxRLiJIldyw 6t/zgIybyjwSe1wZ0U7o1IcoJZ+KSg9Sfmp6tz4+MvqphBFecID+QPF8irOznJgaHJPh vHSPN6Ttclll/q4hJzpo/nJRpu4URTy/RbzgUgi+ix6FGChY7r5J6e2xGBIqDAVCfqqJ LLs1mirP270Z1flAyCk5RooD6gaIa/rj1HoRIp6elO2xfX40fonzpf5xTRQVOrgOkLMT d+sUMl2xJZsZFNEb7SRY+u9ksUC4nFar33rpC5ECOLPS1sovzWpwmdD3qBQngSBE21Xl yIWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=2yGgsK0xacoBajJU0rwl6zKhrhZfywqOM9uEa4as70c=; b=MPue92uE2hftGb8T7vuHQ1aP5vzOX+IZu041HJYR1ToLxLlCf81GEuqpNeFat7mEWf 1jVDeLEIVeK9OtjdErmCoKMAN6FclKI2O5TyUy0c7+3Pbbkw7R/b84OlA+Uc6HijGKcA VlNQtY1tqlmKiulSrqAgOcMGUD62brQefEl0XrVxN0V4ZWUXPSi1zj/d0IXkMWOyiYFs V44Lw9v43CBdXsUZcSz7dZcgX8uwIehKllcCMG+g9r0K4UIpj0J0sKIK/kyHM3i+9KQb xYnlHLLufQqD6oXhitkE8hce4j5Azbspq9ytDRTxHziRKKCKvYvVn66DdGiW1FVRw2A1 BDFw== X-Gm-Message-State: ALoCoQlpPEDdIsp7u9HW0Ucmz13zg+f1U+nL7OtZtRmlo+j41D/xWmfRCpeuy9GOxcytd6rNLho7 MIME-Version: 1.0 X-Received: by 10.140.99.86 with SMTP id p80mr13259615qge.97.1449172393008; Thu, 03 Dec 2015 11:53:13 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.27.181 with HTTP; Thu, 3 Dec 2015 11:53:12 -0800 (PST) X-Originating-IP: [192.55.54.58] In-Reply-To: References: Date: Thu, 3 Dec 2015 12:53:12 -0700 X-Google-Sender-Auth: aNhThc4og4RZsS3FxZNxED3AQtc Message-ID: Subject: Re: Removing build metadata, for reproducible kernel builds From: Warner Losh To: Ed Maste Cc: "freebsd-arch@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 19:53:14 -0000 On Thu, Dec 3, 2015 at 12:55 AM, Ed Maste wrote: > On 3 December 2015 at 05:51, Warner Losh wrote: > > > > I noted in the review that I don=E2=80=99t like the default being no. > > > > I also don=E2=80=99t like that we=E2=80=99re growing lots of different = knobs that need > > to be set to get a repeatable build. Let=E2=80=99s have one, or barring= that, > > let=E2=80=99s have one that sets all the sub-knobs. > > My hope is that we'll have a reproducible build by default, and that > *no* knobs need to be set. That's what I intend with my patch. I can > rename the knob to WITH_/WITHOUT_REPRODUCIBLE_BUILD though if that's > generally desired. If there's a consensus to default to including the > metadata I'm fine with setting it in make release. I think this an unwise decision in the current form suggested. The kernel metadata has saved my butt enough times I really don't want to see it go by default. But see below for a reasonable (imho) middle ground that would be a good default. > > I think that host and path are more worthless than date and time > > in many environments. Who builds it likewise. Those are all things > > that are likely to change between builds, yet change the kernel > > image. I=E2=80=99d rather see it all gone when this option is in effect= . > > I don't follow -- other than the build iteration number (which I > indeed missed), it is all gone. > Yea I was reading things backwards. In the review, I suggested that if you've modified the tree (which the SCM will tell you), then do the old format to preserve useful metadata that's really really needed and if not to use the shorter version. When you've modified the tree, reproducible builds aren't a concern at all. Warner