From nobody Thu Dec 22 12:54:49 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nd9JG07lDz1HKpC; Thu, 22 Dec 2022 12:54:54 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nd9JF6pmLz4Y0W; Thu, 22 Dec 2022 12:54:53 +0000 (UTC) (envelope-from garga@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671713694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y2rLwvlOGEKDpGMa2GB7F0mOmDubHFUzqI7WzmKGVFw=; b=fS5ygH3vZt9GcxXEcyoFnePyT1tlYeHzLGijNaoLthGLXlVKYMrHYib5D62mrmLuAdpqA9 HtIPcKQVeYdNohxEFQut+isXmTjeDoX/fFz71IXb16hAhOdRDM2edwb5XhjBHC4wovZItZ 5ODyhtf81CXzgPbTXVGSfEm1KxnbGxl8t1hp8dvzMWxqTSf0TGKBpLBNy0xQ3CtiQMr2uR u0dWBx/A1QwbQNvRiVw7NFrt4GhSB5x9j+b1O7i9DyTeu3gm3U+W3QU2z3xaWJ+1ft3BUi hm0mrdfkq3/z5jh+gyuz295BcGS1CY+aJwN0T4+u+YjsUkyLRrGxC9BaPvZwJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671713694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y2rLwvlOGEKDpGMa2GB7F0mOmDubHFUzqI7WzmKGVFw=; b=Iamq9owpiAw0a+DDp5MSqqEjD1G1Z6eNpUF2OMH9T9CoCvNGRExEItbAaMqqrvw6zIMWUk dAxOqihu+RHYUf5TnGVvw31mCH5pZmf/hX0Fh6s8IbUq5uaSbepLIwx0S/OANdh0Cf5XeS C24IvD2pEdIAIYSafrduLY2AROv/+8WnVF1ujD3ZiEhRFQsRc97ANctQ1hF/M+W2bhx3Ht YUicjTfJ64JYId/Ykklxm+OV1D4eZCP97dq7/zQ5u64Jar5rSTCSH6r4Od+2CLkQVBODMg Y2G74KJlqmg6T8blwfe87AqC+lrRGFgHLg/zJN1mrXUJGRTDEt9S7yw8FfpXvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671713694; a=rsa-sha256; cv=none; b=GEX9FCLPtRPrzZO/wqjRhltlyFlk7Xw9AQCkc9NEDwyQhk0Krp0J945oXvUZSY2S//Ij2z GAsd+0slcfkDJNoKQ2BNClVRdTeavIt+iV+86Q/dWSrsSWltkcXZIdEVL+xYUPuuJQLikW ZU0Rhena3Mp//2fmLt5HvNUD7we3sqdhntW37A7H83vVYC9pNbj6TdsalW1GMH1uonnDsK H3jYa9RE7qAU1lhA838rR4TmvN4SzJYt1nMwshPD57tQSRRBPMbHjxg1cSReZuICdQiv6I 4N4BQ5eTcn9lf3xh5R8IhLp5CNpvN3splarKcsDh2PivJq50NqF8Bq6d9rh9qQ== Received: from [IPV6:2804:f1c:811:f000:a075:194e:bb9f:743a] (unknown [IPv6:2804:f1c:811:f000:a075:194e:bb9f:743a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Nd9JF0yw5z11YN; Thu, 22 Dec 2022 12:54:52 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: <15072738-61b4-f3cb-25b8-86c718559eab@FreeBSD.org> Date: Thu, 22 Dec 2022 09:54:49 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: git: 269c564b90d3 - main - vfs: retire NDFREE Content-Language: en-US To: Mateusz Guzik Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202212190814.2BJ8EcoL052955@gitrepo.freebsd.org> <80ce4bdc-70b9-fb4e-a248-a9be0d453dd4@FreeBSD.org> From: Renato Botelho In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 22/12/22 09:29, Mateusz Guzik wrote: > diff -ru open-vm-tools-stable-12.0.0/open-vm-tools/modules/freebsd/vmblock/vfsops.c > open-vm-tools-stable-12.0.0.patched/open-vm-tools/modules/freebsd/vmblock/vfsops.c > --- open-vm-tools-stable-12.0.0/open-vm-tools/modules/freebsd/vmblock/vfsops.c > 2022-03-04 21:01:24.000000000 +0000 > +++ open-vm-tools-stable-12.0.0.patched/open-vm-tools/modules/freebsd/vmblock/vfsops.c > 2022-12-22 12:27:51.897759000 +0000 > @@ -174,11 +174,14 @@ > NDINIT(ndp, LOOKUP, FOLLOW|LOCKLEAF, UIO_SYSSPACE, target, compat_td); > error = namei(ndp); > if (error) { > - NDFREE(ndp, 0); > uma_zfree(VMBlockPathnameZone, pathname); > return error; > } > +#if __FreeBSD_version < 1400075 > NDFREE(ndp, NDF_ONLY_PNBUF); > +#else > + NDFREE_PNBUF(ndp); > +#endif This patch fails on OSVERSION 1400074 with the same error that happened in the past when NDF_ONLY_PNBUF was retired --- vfsops.o --- vfsops.c:185:16: error: use of undeclared identifier 'NDF_ONLY_PNBUF' NDFREE(ndp, NDF_ONLY_PNBUF); I'll keep it checking if NDF_ONLY_PNBUF is defined to decide to call NDFREE or NDFREE_PNBUF -- Renato Botelho