From owner-freebsd-pf@freebsd.org  Wed Mar 10 19:48:18 2021
Return-Path: <owner-freebsd-pf@freebsd.org>
Delivered-To: freebsd-pf@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id EB56A575811
 for <freebsd-pf@mailman.nyi.freebsd.org>; Wed, 10 Mar 2021 19:48:18 +0000 (UTC)
 (envelope-from kp@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DwjLB6RqFz4Zjb;
 Wed, 10 Mar 2021 19:48:18 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from venus.codepro.be (venus.codepro.be [5.9.86.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mx1.codepro.be", Issuer "R3" (verified OK))
 (Authenticated sender: kp)
 by smtp.freebsd.org (Postfix) with ESMTPSA id B5A723EF9;
 Wed, 10 Mar 2021 19:48:18 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: by venus.codepro.be (Postfix, authenticated sender kp) id 7FC33BCA5;
 Wed, 10 Mar 2021 20:48:16 +0100 (CET)
From: "Kristof Provost" <kp@FreeBSD.org>
To: "Patrick Lamaiziere" <patfbsd@davenulle.org>
Cc: freebsd-pf@freebsd.org
Subject: Re: pfctl segmentation fault in pfctl_optimize.c
Date: Wed, 10 Mar 2021 20:48:15 +0100
X-Mailer: MailMate (1.13.2r5673)
Message-ID: <CFC9AFC8-85F4-4E84-8C51-22AC0E392BF9@FreeBSD.org>
In-Reply-To: <20210309110530.63834499@mr185033.univ-rennes1.fr>
References: <20210309110530.63834499@mr185033.univ-rennes1.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
 \(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf/>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Mar 2021 19:48:19 -0000

On 9 Mar 2021, at 11:05, Patrick Lamaiziere wrote:
> Hello,
>
> FreeBSD 11.4-RELEASE-p3 / amd64
>
> Yesterday while loading a ruleset, pfctl core dumped with a
> segmentation fault (see gdb below)
>
> We are recently using some big tables so may be this is what triggered 
> the problem (?), i can't reproduce this.
>
> I've found something on tech@openbsd.org that looks closely related:
> https://www.mail-archive.com/tech@openbsd.org/msg42870.html
>
At first glance that looks like a sane change, but I can’t reproduce 
the crash described there.

Can you reproduce your crash? I try to avoid making changes I can’t 
write a test for.

Best regards,
Kristof