From owner-freebsd-current@FreeBSD.ORG Sun Jun 3 08:54:14 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 48AA11065672; Sun, 3 Jun 2012 08:54:14 +0000 (UTC) (envelope-from guru@unixarea.de) Received: from ms16-1.1blu.de (ms16-1.1blu.de [89.202.0.34]) by mx1.freebsd.org (Postfix) with ESMTP id CEA328FC0A; Sun, 3 Jun 2012 08:54:13 +0000 (UTC) Received: from [188.174.51.73] (helo=localhost.my.domain) by ms16-1.1blu.de with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Sb6Za-0004PO-Ml; Sun, 03 Jun 2012 10:54:07 +0200 Received: from localhost.my.domain (localhost [127.0.0.1]) by localhost.my.domain (8.14.4/8.14.3) with ESMTP id q538s49N017512; Sun, 3 Jun 2012 10:54:04 +0200 (CEST) (envelope-from guru@unixarea.de) Received: (from guru@localhost) by localhost.my.domain (8.14.4/8.14.3/Submit) id q538s4mT017511; Sun, 3 Jun 2012 10:54:04 +0200 (CEST) (envelope-from guru@unixarea.de) X-Authentication-Warning: localhost.my.domain: guru set sender to guru@unixarea.de using -f Date: Sun, 3 Jun 2012 10:54:03 +0200 From: Matthias Apitz To: John Baldwin Message-ID: <20120603085402.GA6129@tinyCurrent> References: <20120526142229.GA3893@tinyCurrent> <201205311134.55258.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201205311134.55258.jhb@freebsd.org> X-Operating-System: FreeBSD 9.0-CURRENT r214444 (i386) User-Agent: Mutt/1.5.21 (2010-09-15) X-Con-Id: 51246 X-Con-U: 0-guru X-Originating-IP: 188.174.51.73 Cc: swills@freebsd.org, freebsd-current@freebsd.org Subject: Re: 10-CURRENT r235646 && open-vm-tools-8.6.0-425873 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthias Apitz List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2012 08:54:14 -0000 El día Thursday, May 31, 2012 a las 11:34:55AM -0400, John Baldwin escribió: > On Saturday, May 26, 2012 10:22:29 am Matthias Apitz wrote: > > > > Hi, > > > > The port ports/emulators/open-vm-tools does not compile in 10-CURRENT: > > > > # make install clean > > ... > > ... > > if_vxn.c:719: warning: implicit declaration of function 'IF_ADDR_LOCK' > > if_vxn.c:719: warning: nested extern declaration of 'IF_ADDR_LOCK' > > [-Wnested-ext erns] > > if_vxn.c:746: warning: implicit declaration of function 'IF_ADDR_UNLOCK' > > if_vxn.c:746: warning: nested extern declaration of 'IF_ADDR_UNLOCK' > > [-Wnested-e xterns] > > *** [if_vxn.o] Error code 1 > > > > Let me know if you need more information. > > Thanks > > It should be using if_mcast_rlock() and if_mcast_runlock() instead of using > those macros directly. This works all the way back to 8.0. Hi, Is there a patch or some example how to replace IF_ADDR_LOCK/IF_ADDR_UNLOCK by if_mcast_rlock() and if_mcast_runlock()? The code in the above source looks like this: modules/freebsd/vmxnet/net_compat.h: ... #if __FreeBSD_version < 505000 # define VXN_IF_ADDR_LOCK(_ifp) # define VXN_IF_ADDR_UNLOCK(_ifp) #else # define VXN_IF_ADDR_LOCK(_ifp) IF_ADDR_LOCK((_ifp)) # define VXN_IF_ADDR_UNLOCK(_ifp) IF_ADDR_UNLOCK((_ifp)) #endif modules/freebsd/vmxnet/if_vxn.c ... vxn_load_multicast(vxn_softc_t *sc) { struct ifmultiaddr *ifma; struct ifnet *ifp = VXN_SC2IFP(sc); ... VXN_IF_ADDR_LOCK(ifp); ... VXN_IF_ADDR_UNLOCK(ifp); ... Thanks matthias -- Matthias Apitz t +49-89-61308 351 - f +49-89-61308 399 - m +49-170-4527211 e - w http://www.unixarea.de/ UNIX since V7 on PDP-11 | UNIX on mainframe since ESER 1055 (IBM /370) UNIX on x86 since SVR4.2 UnixWare 2.1.2 | FreeBSD since 2.2.5