From owner-svn-src-head@FreeBSD.ORG Fri Oct 19 22:05:52 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C73BC565; Fri, 19 Oct 2012 22:05:52 +0000 (UTC) (envelope-from edschouten@gmail.com) Received: from mail-oa0-f54.google.com (mail-oa0-f54.google.com [209.85.219.54]) by mx1.freebsd.org (Postfix) with ESMTP id 55E3D8FC0A; Fri, 19 Oct 2012 22:05:52 +0000 (UTC) Received: by mail-oa0-f54.google.com with SMTP id n9so1202776oag.13 for ; Fri, 19 Oct 2012 15:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=pPwWkzthmuZsPIkcjySkHz3n6Ck2/pMx/kyqgTvElws=; b=Sah5QFs63NyzmvxHVpB0L0zh8MWisFrgNaK93hrHFaz2d+NrhJyVL0bnxph6MBeJci TNaCZWOac/ZrvlEbhXkWagTGD+dVOr+4O7Uk+EYI/nG8OKCkDufkhhhp2qfpsPIhEL6+ gTJjPzIS2HaCA/vka0BIbFaP4mPVab303iTYsC49fXAPZBpppYHjY1UY3Ou9jLcXJhiK fDh8iYPaOBxZ+2SDYkKCgPugtOWGUa33mF6D8cWSqWq87LqcwlS4nCN+0DMtQ0YrmO4h R/oj/YZABCDxhfGUgGFqNEue0jnuj/Eb+xTw4a60gsBCGbtEly++CcL4gfUIhGheB6BX KLDQ== MIME-Version: 1.0 Received: by 10.60.32.243 with SMTP id m19mr2837813oei.21.1350684350469; Fri, 19 Oct 2012 15:05:50 -0700 (PDT) Sender: edschouten@gmail.com Received: by 10.76.151.39 with HTTP; Fri, 19 Oct 2012 15:05:50 -0700 (PDT) In-Reply-To: <201210191118.42722.jhb@freebsd.org> References: <201210191449.q9JEnhfn015510@svn.freebsd.org> <201210191118.42722.jhb@freebsd.org> Date: Sat, 20 Oct 2012 00:05:50 +0200 X-Google-Sender-Auth: HNP17diJK2Pht7S2jFmNteNpMyo Message-ID: Subject: Re: svn commit: r241737 - in head: bin/date bin/ed libexec/rtld-aout sbin/camcontrol sbin/geom/core usr.bin/at usr.bin/calendar usr.bin/chat usr.bin/ctlstat usr.bin/elfdump usr.bin/fetch usr.bin/finger... From: Ed Schouten To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2012 22:05:52 -0000 Hi John, 2012/10/19 John Baldwin : > The fw_* changes here probably wasn't the right way to fix this. The > variables should be static. The problem is that 'scan_firmware()' is > duplicated and should probably be reduced to a single copy. Good catch! Will fix! -- Ed Schouten