From owner-freebsd-bugs@FreeBSD.ORG Fri Jul 4 14:00:29 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 295E537B494 for ; Fri, 4 Jul 2003 14:00:29 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABBC34401F for ; Fri, 4 Jul 2003 14:00:27 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h64L0RUp095431 for ; Fri, 4 Jul 2003 14:00:27 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h64L0R05095430; Fri, 4 Jul 2003 14:00:27 -0700 (PDT) Resent-Date: Fri, 4 Jul 2003 14:00:27 -0700 (PDT) Resent-Message-Id: <200307042100.h64L0R05095430@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Lukas Ertl Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F3DE37B401 for ; Fri, 4 Jul 2003 13:50:37 -0700 (PDT) Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 01C1A43FAF for ; Fri, 4 Jul 2003 13:50:36 -0700 (PDT) (envelope-from le@univie.ac.at) Received: from korben.in.tern (adslle.cc.univie.ac.at [131.130.102.11]) by mailbox.univie.ac.at (8.12.2/8.12.2) with ESMTP id h64KoLdS167670 for ; Fri, 4 Jul 2003 22:50:27 +0200 Received: from korben.in.tern (korben.in.tern [127.0.0.1]) by korben.in.tern (8.12.9/8.12.9) with ESMTP id h64KoIRR001050 for ; Fri, 4 Jul 2003 22:50:19 +0200 (CEST) (envelope-from le@korben.in.tern) Received: (from le@localhost) by korben.in.tern (8.12.9/8.12.9/Submit) id h64KoI9m001049; Fri, 4 Jul 2003 22:50:18 +0200 (CEST) (envelope-from le) Message-Id: <200307042050.h64KoI9m001049@korben.in.tern> Date: Fri, 4 Jul 2003 22:50:18 +0200 (CEST) From: Lukas Ertl To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/54113: [PATCH] devd(8) doesn't write correct pid into /var/run/devd.pid X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Lukas Ertl List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jul 2003 21:00:29 -0000 >Number: 54113 >Category: bin >Synopsis: [PATCH] devd(8) doesn't write correct pid into /var/run/devd.pid >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jul 04 14:00:27 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Lukas Ertl >Release: FreeBSD 5.1-CURRENT i386 >Organization: Vienna University Computer Center >Environment: System: FreeBSD korben 5.1-CURRENT FreeBSD 5.1-CURRENT #20: Fri Jul 4 18:38:33 CEST 2003 le@korben:/usr/obj/usr/src/sys/KORBEN i386 >Description: devd(8) writes its pid into /var/run/devd.pid, but the pid there is 1 lower than the actual pid of devd. This is because devd is started by default without the -n switch, so it writes the pidfile before calling daemon(8). >How-To-Repeat: # devd # cat /var/run/devd.pid 720 # ps auxww | grep devd root 721 0,0 0,2 772 532 ?? Is 10:22pm 0:00,00 devd >Fix: Simply write the pidfile again after calling daemon(3). --- devd.diff begins here --- Index: sbin/devd/devd.cc =================================================================== RCS file: /usr/local/bsdcvs/src/sbin/devd/devd.cc,v retrieving revision 1.14 diff -u -r1.14 devd.cc --- sbin/devd/devd.cc 2 May 2003 17:38:08 -0000 1.14 +++ sbin/devd/devd.cc 4 Jul 2003 20:42:21 -0000 @@ -596,6 +596,7 @@ if (Dflag) fprintf(stderr, "Calling daemon\n"); daemon(0, 0); + cfg.drop_pidfile(); once++; } } --- devd.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: