From nobody Fri Aug 1 12:09:53 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4btlBT6wfVz63q7P; Fri, 01 Aug 2025 12:09:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4btlBT6Phsz3KkK; Fri, 01 Aug 2025 12:09:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754050193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sNXIOSjKeoEBVieJWXFUC1g1759jcSr8bu47SITaQLU=; b=K+WnO68iWZ47Wr7cQvs/34C+uY4Vf/ZVI0SuewSyFmw4npau+h/SbKGlbwPz5Pmt/2yAcQ Nn1HYWfIbLddoOQKQZhBv3RhcABXOfR8n5vL707poLb8U9DTLNM8S/IRTIldL6Bb5jETO4 AA+DsTFrSUhl0j7DXhrkk5ron87WmGMai3QuNRC7Vf4H0P7rPOQsDrHK8WPuzkk0Te1wS8 QhX8de59rjUT4EtaUtWm2IgVCQLvoGOFPztDDVNI9uDGj6Eo7Hfa29l1T/T541gsJyjkzr 7iXe8N8Cd3DAuc/dnEWdeEfCzuobL0oxs0dgrUmYzWhg4EHxIaa8pGxNmibQoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754050193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sNXIOSjKeoEBVieJWXFUC1g1759jcSr8bu47SITaQLU=; b=oqPtiz4uotwjBF6Et+qup7oaPWLDZE9zbtUvJ4x/Goh+EVUOQgXRT4rVY6hm6iAIoN7T9B /J/gWs+qkt9Mumc/GEs5xrKGcJarPYzPoMrM5PDwQcxDShFskhxhyVZni8NTsPMuSQRr+9 FCduQX2J5yMq9Zc/0TffGD4MRvisJ/tpSMnPI8gwqfCVzieLP6WHmc34RLhcUc72tjEyWC sulxQee+XZYfTeMtjsNcXdi2nvRHP0BJfS7H86w+UK+XpYLb9bBKZe3Kcw9/HmcrloNyxp pArSkBjIDsjM4+GrhJJXPkQVz8uqIPA/JyEfdONQFj89/FF52zWH4Qsth705hA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754050193; a=rsa-sha256; cv=none; b=l1m+KRg8JkD5vktj7gxn7QwVX+wPczAvLLGWjEUddZZn+fqxXd2XDlfn0c1uA+2WegPOZU 8pI82YwfwsYMaDbRhJo9sUd5zr0UtDBkaLClwZ6+xyOZYw3zc13lMAsoICnYDjt6iGzP4F DoCcaWxl9HoNkddR0MEyAOeF3JuZOjCIpoK1ZXBVX27ve67xG2VDyqnoe6A11V7g27MqJl UYjeLNO2itnB4IJFgrN0Bs7s4h/00sVF+JtjQAiOJJmAL9YLwTBAkCb/Kq/0YW4LLlFPI0 6v/1II4zvo55ivoLCDAqeuBQIrOXVi1llAoR+GM9CIAi6FayEv5jH+X2/ezIsQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4btlBT57kDznGZ; Fri, 01 Aug 2025 12:09:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 571C9rXU097287; Fri, 1 Aug 2025 12:09:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 571C9r9i097284; Fri, 1 Aug 2025 12:09:53 GMT (envelope-from git) Date: Fri, 1 Aug 2025 12:09:53 GMT Message-Id: <202508011209.571C9r9i097284@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: 118bfc9f53ac - main - arm64: Fix the sign in ID registers List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 118bfc9f53ac9abfc58078195b35e293bbfb8136 Auto-Submitted: auto-generated The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=118bfc9f53ac9abfc58078195b35e293bbfb8136 commit 118bfc9f53ac9abfc58078195b35e293bbfb8136 Author: Andrew Turner AuthorDate: 2025-07-30 10:51:20 +0000 Commit: Andrew Turner CommitDate: 2025-07-30 12:46:22 +0000 arm64: Fix the sign in ID registers Some ID registers use 0b0000 to indicate a feature is enabled, and 0b1111 to indicate it's not. In these cases we need to tell the kernel to treat the value as a signed field. Set the signed flag in fields we decode that should be signed. Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D51369 --- sys/arm64/arm64/identcpu.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sys/arm64/arm64/identcpu.c b/sys/arm64/arm64/identcpu.c index 49b4b25b51bb..55f7e98a1b1b 100644 --- a/sys/arm64/arm64/identcpu.c +++ b/sys/arm64/arm64/identcpu.c @@ -618,7 +618,7 @@ static const struct mrs_field id_aa64dfr0_fields[] = { id_aa64dfr0_tracebuffer), MRS_FIELD(ID_AA64DFR0, TraceFilt, false, MRS_LOWER, 0, id_aa64dfr0_tracefilt), - MRS_FIELD(ID_AA64DFR0, DoubleLock, false, MRS_LOWER, 0, + MRS_FIELD(ID_AA64DFR0, DoubleLock, true, MRS_LOWER, 0, id_aa64dfr0_doublelock), MRS_FIELD(ID_AA64DFR0, PMSVer, false, MRS_LOWER, 0, id_aa64dfr0_pmsver), MRS_FIELD(ID_AA64DFR0, CTX_CMPs, false, MRS_LOWER, 0, @@ -628,7 +628,7 @@ static const struct mrs_field id_aa64dfr0_fields[] = { MRS_FIELD(ID_AA64DFR0, PMSS, false, MRS_LOWER, 0, id_aa64dfr0_pmss), MRS_FIELD(ID_AA64DFR0, BRPs, false, MRS_LOWER, MRS_USERSPACE, id_aa64dfr0_brps), - MRS_FIELD(ID_AA64DFR0, PMUVer, false, MRS_LOWER, 0, id_aa64dfr0_pmuver), + MRS_FIELD(ID_AA64DFR0, PMUVer, true, MRS_LOWER, 0, id_aa64dfr0_pmuver), MRS_FIELD(ID_AA64DFR0, TraceVer, false, MRS_LOWER, 0, id_aa64dfr0_tracever), MRS_FIELD(ID_AA64DFR0, DebugVer, false, MRS_LOWER | MRS_SAFE(0x6), 0, @@ -1259,9 +1259,9 @@ static const struct mrs_field id_aa64mmfr0_fields[] = { id_aa64mmfr0_tgran64_2), MRS_FIELD(ID_AA64MMFR0, TGran16_2, false, MRS_LOWER, 0, id_aa64mmfr0_tgran16_2), - MRS_FIELD(ID_AA64MMFR0, TGran4, false, MRS_LOWER, 0, + MRS_FIELD(ID_AA64MMFR0, TGran4, true, MRS_LOWER, 0, id_aa64mmfr0_tgran4), - MRS_FIELD(ID_AA64MMFR0, TGran64, false, MRS_LOWER, 0, + MRS_FIELD(ID_AA64MMFR0, TGran64, true, MRS_LOWER, 0, id_aa64mmfr0_tgran64), MRS_FIELD(ID_AA64MMFR0, TGran16, false, MRS_LOWER, 0, id_aa64mmfr0_tgran16), @@ -1856,7 +1856,8 @@ static const struct mrs_field id_aa64pfr1_fields[] = { MRS_FIELD(ID_AA64PFR1, DF2, false, MRS_LOWER, 0, id_aa64pfr1_df2), MRS_FIELD(ID_AA64PFR1, MTEX, false, MRS_LOWER, 0, id_aa64pfr1_mtex), MRS_FIELD(ID_AA64PFR1, THE, false, MRS_LOWER, 0, id_aa64pfr1_the), - MRS_FIELD(ID_AA64PFR1, MTE_frac, false, MRS_LOWER, 0, id_aa64pfr1_mtefrac), + MRS_FIELD(ID_AA64PFR1, MTE_frac, true, MRS_LOWER, 0, + id_aa64pfr1_mtefrac), MRS_FIELD(ID_AA64PFR1, NMI, false, MRS_LOWER, 0, id_aa64pfr1_nmi), MRS_FIELD(ID_AA64PFR1, CSV2_frac, false, MRS_LOWER, 0, id_aa64pfr1_csv2_frac),