From owner-freebsd-current@FreeBSD.ORG Sun Jan 30 16:35:57 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 142E416A4CE for ; Sun, 30 Jan 2005 16:35:57 +0000 (GMT) Received: from av3-2-sn4.m-sp.skanova.net (av3-2-sn4.m-sp.skanova.net [81.228.10.113]) by mx1.FreeBSD.org (Postfix) with ESMTP id 548D743D45 for ; Sun, 30 Jan 2005 16:35:56 +0000 (GMT) (envelope-from lothrandil@n00b.apagnu.se) Received: by av3-2-sn4.m-sp.skanova.net (Postfix, from userid 502) id 8874837E44; Sun, 30 Jan 2005 17:35:55 +0100 (CET) Received: from smtp2-2-sn4.m-sp.skanova.net (smtp2-2-sn4.m-sp.skanova.net [81.228.10.182]) by av3-2-sn4.m-sp.skanova.net (Postfix) with ESMTP id 7970E37E43 for ; Sun, 30 Jan 2005 17:35:55 +0100 (CET) Received: from [217.208.32.115] (h115n2fls31o926.telia.com [217.208.32.115]) by smtp2-2-sn4.m-sp.skanova.net (Postfix) with ESMTP id 4B82537E43 for ; Sun, 30 Jan 2005 17:35:55 +0100 (CET) Message-ID: <41FD0CE3.8070406@n00b.apagnu.se> Date: Sun, 30 Jan 2005 17:35:47 +0100 From: Niclas Zeising User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: current@freebsd.org Content-Type: multipart/mixed; boundary="------------030805010204010903060103" Subject: [PATCH] Kernel module compile faliure in mcd X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jan 2005 16:35:57 -0000 This is a multi-part message in MIME format. --------------030805010204010903060103 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Don't know if this should be filed as a pr, but as the fix is trivial and just need to be committed (I belive) i send it here. Please correct me if i should file a PR. In rev 1.145 of src/sys/dev/mcd/mcd.c there is a typo which makes the kernel build fail. On line 1432 there is a return(0) missing an ending ';'. Patch included. Cheers! //Niclas -- --------------030805010204010903060103 Content-Type: text/plain; name="mcd.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mcd.c.diff" --- mcd.c.orig 2005-01-30 17:20:14.000000000 +0100 +++ mcd.c 2005-01-30 17:34:30.000000000 +0100 @@ -1429,7 +1429,7 @@ if (nocopyout == 0) return copyout(&data, sch->data, min(sizeof(struct cd_sub_channel_info), sch->data_len)); bcopy(&data, sch->data, min(sizeof(struct cd_sub_channel_info), sch->data_len)); - return (0) + return (0); } static int --------------030805010204010903060103--