Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Jun 2015 12:59:05 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Adrian Chadd <adrian@FreeBSD.org>
Cc:        "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org>
Subject:   Re: [rfc] add support routines required for gcc-4.9
Message-ID:  <BD7C3709-7283-4074-BE3F-C73D18B38398@bsdimp.com>
In-Reply-To: <CAJ-Vmo=ntwpSti=MO47%2BdFvtohG2wx7x2%2Bc-MH5b0Pc%2BuU7=EA@mail.gmail.com>
References:  <CAJ-Vmo=ntwpSti=MO47%2BdFvtohG2wx7x2%2Bc-MH5b0Pc%2BuU7=EA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]

> On Jun 18, 2015, at 8:51 AM, Adrian Chadd <adrian@FreeBSD.org> wrote:
> 
> -adrian
> The following is neded for gcc-4.9, as it doesn't supply these inline functions.
> 
> What do people think?
> 
> adrian@lucy-11i386:~/work/freebsd/head-embedded-2/src % svn diff
> sys/conf/files.mips
> Index: sys/conf/files.mips
> ===================================================================
> --- sys/conf/files.mips (revision 284394)
> +++ sys/conf/files.mips (working copy)
> @@ -61,6 +61,9 @@
> libkern/memmove.c                      standard
> libkern/cmpdi2.c                       optional        mips | mipsel
> libkern/ucmpdi2.c                      optional        mips | mipsel
> +# required for gcc-4.9?

I’d just remove this comment. Otherwise this looks great to me. The few extra bytes
from this code are so far in the noise having it be more specifically conditional
isn’t worth the effort.

Warner

> +libkern/ashldi3.c                      standard
> +libkern/ashrdi3.c                      standard
> 
> # cfe support
> dev/cfe/cfe_api.c                      optional        cfe
> 
> -adrian
> _______________________________________________
> freebsd-mips@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-mips
> To unsubscribe, send any mail to "freebsd-mips-unsubscribe@freebsd.org"


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJVgxT6AAoJEGwc0Sh9sBEATgoP+gL31G9ZiHyW9j5M/kZWvH9i
Nn08a/5wSCSIgbiYDXtgMmBDYv3v0Ga6dGJO/Xs03bvD762dSQs5JXEY1a2aqcvM
cTN43jwBP+4GBkMkHNlUd8hGTyzbn6w/RnUEvGx6xcNHq51YJUAlN0f+BihJ4PWY
ViRPCVdB3cARjhexMvUY7A5hUdY7Y8Rxr34p1SBGZRKgChCRnq2wC547gdVYdkPa
Z7norOl7iT5fFQyezKEYp+MG8kj5Z5zryUqV2ZJW7M6pmQ96QXHvjTwVsmr2UPpT
0teR5UbPhOAD8N/KoPqJD8NiZBUQ9JnvM4CUJZA0XJy4XqM/rV66kbh92FTTa/9w
ZgRCIIuZi48gZTvTQzkAz1QKeQdOAFreMKi6TeKvxzeX+UZjNF2J7zPQ5QBvCuWo
Kki7KZYDqnC4ojnyGrCEsEfGxIkoqMH+gLSrv18dIPsZwHop2uH2kpDHS5B0yQpc
8LitowpWM6PJGMwcQ+F9aWQ18OfjzZ0gvfuffOFhywbSdMdVMHsitoezf+N1OeV1
fCFnlH277bgo/X3RAg2V+UHF9/8ei+0zObCmH4odDN1AJglbaZtnpOXVbddE6y2V
7pdZMNbjYfj/EIe4neamu8v6nRJQxVZtM0COz726ZOqndKMp6Q96lV8PiW17Vvds
RmSt0V0YlBaXiYF5wGF0
=ZhRw
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BD7C3709-7283-4074-BE3F-C73D18B38398>