From owner-svn-src-all@freebsd.org Thu Dec 24 18:01:00 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32ABCA51C95; Thu, 24 Dec 2015 18:01:00 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A5FB817FD; Thu, 24 Dec 2015 18:00:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tBOI0rLJ058191 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 24 Dec 2015 20:00:53 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tBOI0rLJ058191 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tBOI0rNK058190; Thu, 24 Dec 2015 20:00:53 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 24 Dec 2015 20:00:53 +0200 From: Konstantin Belousov To: Ian Lepore Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291937 - in head: lib/libc/aarch64/sys lib/libc/arm/sys sys/arm/arm sys/arm/include sys/arm64/arm64 sys/arm64/include sys/conf sys/kern Message-ID: <20151224180053.GY3625@kib.kiev.ua> References: <201512071220.tB7CKRw0027858@repo.freebsd.org> <1450971642.25138.247.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450971642.25138.247.camel@freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2015 18:01:00 -0000 On Thu, Dec 24, 2015 at 08:40:42AM -0700, Ian Lepore wrote: > On Mon, 2015-12-07 at 12:20 +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Mon Dec 7 12:20:26 2015 > > New Revision: 291937 > > URL: https://svnweb.freebsd.org/changeset/base/291937 > > > > Log: > > Add support for usermode (vdso-like) gettimeofday(2) and > > clock_gettime(2) on ARMv7 and ARMv8 systems which have architectural > > generic timer hardware. It is similar how the RDTSC timer is used in > > userspace on x86. > > > > Fix a permission problem where generic timer access from EL0 (or > > userspace on v7) was not properly initialized on APs. > > > > For ARMv7, mark the stack non-executable. The shared page is added for > > all arms (including ARMv8 64bit), and the signal trampoline code is > > moved to the page. > > > > Reviewed by:> > andrew > > Discussed with:> > emaste, mmel > > Sponsored by:> > The FreeBSD Foundation > > Differential revision:> https://reviews.freebsd.org/D4209 > > I've just discovered this change breaks buildworld on armv4/5 systems. > Those systems don't have the counter hardware that can be read from > userland (they don't have any common timer hardware at all, every > system is different). Also, they don't support the 'mrrc' instruction, > so the buildworld fails to compile libc. I tested the change with make universe. Is the armv5 world included into the make ? If yes, there is something even more broken. That said, the code in __vdso_gettime.c is unused om armv4/v5 since kernel never directs libc to use a fast timecounter. The routines could be left undefined since they are declared weak, or the bodies could be stubbed out. Anyway, to test, I should be able to compile libc for the target. And, BTW, what is exactly your error message ?