From owner-svn-src-all@freebsd.org Mon Aug 27 10:18:38 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7655F108375D; Mon, 27 Aug 2018 10:18:38 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 127468891D; Mon, 27 Aug 2018 10:18:34 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id A85FE260189; Mon, 27 Aug 2018 12:18:26 +0200 (CEST) Subject: Re: svn commit: r337943 - head/sys/net To: Navdeep Parhar , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201808170103.w7H13Nl5047960@repo.freebsd.org> From: Hans Petter Selasky Message-ID: Date: Mon, 27 Aug 2018 12:18:02 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <201808170103.w7H13Nl5047960@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2018 10:18:38 -0000 On 8/17/18 3:03 AM, Navdeep Parhar wrote: > Author: np > Date: Fri Aug 17 01:03:23 2018 > New Revision: 337943 > URL: https://svnweb.freebsd.org/changeset/base/337943 > > Log: > if_vlan(4): A VLAN always has a PCP and its ifnet's if_pcp should be set > to the PCP value in use instead of IFNET_PCP_NONE. > > MFC after: 1 week > Sponsored by: Chelsio Communications > > Modified: > head/sys/net/if_vlan.c > > Modified: head/sys/net/if_vlan.c > ============================================================================== > --- head/sys/net/if_vlan.c Fri Aug 17 00:49:35 2018 (r337942) > +++ head/sys/net/if_vlan.c Fri Aug 17 01:03:23 2018 (r337943) > @@ -1435,6 +1435,7 @@ vlan_config(struct ifvlan *ifv, struct ifnet *p, uint1 > ifp->if_resolvemulti = p->if_resolvemulti; > ifp->if_addrlen = p->if_addrlen; > ifp->if_broadcastaddr = p->if_broadcastaddr; > + ifp->if_pcp = ifv->ifv_pcp; > > /* > * Copy only a selected subset of flags from the parent. > @@ -1959,6 +1960,7 @@ vlan_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data > break; > } > ifv->ifv_pcp = ifr->ifr_vlan_pcp; > + ifp->if_pcp = ifv->ifv_pcp; > vlan_tag_recalculate(ifv); > /* broadcast event about PCP change */ > EVENTHANDLER_INVOKE(ifnet_event, ifp, IFNET_EVENT_PCP); Hi Navdeep, FYI: This patch currently breaks OFED, because OFED doesn't expect if_pcp to be different from the NONE value with VLAN interfaces. Mellanox is working on a fix. --HPS