Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Jul 2019 13:34:13 +1000
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        Brooks Davis <brooks@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r506765 - head/devel/llvm-devel
Message-ID:  <7110fac2-3489-dd83-be5d-ceba196f1c51@FreeBSD.org>
In-Reply-To: <201907161640.x6GGe6KH040369@repo.freebsd.org>
References:  <201907161640.x6GGe6KH040369@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 17/07/2019 2:40 am, Brooks Davis wrote:
> Author: brooks
> Date: Tue Jul 16 16:40:06 2019
> New Revision: 506765
> URL: https://svnweb.freebsd.org/changeset/ports/506765
> 
> Log:
>    Pin the python version to 3.6 to fix builds with 2.7 as the default.
>    
>    It appears that LLVM recently become more aggressive in finding python 3
>    installations and strongly prefers them.
>    
>    No PORTREVISON bump as I expect only previously broken systems to see any
>    changes.
>    
>    PR:		239237
>    Reported by:	jbeich
> 
> Modified:
>    head/devel/llvm-devel/Makefile
> 
> Modified: head/devel/llvm-devel/Makefile
> ==============================================================================
> --- head/devel/llvm-devel/Makefile	Tue Jul 16 16:36:32 2019	(r506764)
> +++ head/devel/llvm-devel/Makefile	Tue Jul 16 16:40:06 2019	(r506765)
> @@ -27,7 +27,7 @@ BUILD_DEPENDS=
>   USES=		cmake compiler:c++11-lib libedit perl5 \
>   		shebangfix
>   USE_LDCONFIG=	${LLVM_PREFIX}/lib
> -_USES_PYTHON?=	python:build
> +_USES_PYTHON?=	python:build:3.6
>   USES+=		${_USES_PYTHON}
>   SHEBANG_FILES=	utils/lit/lit.py utils/llvm-lit/llvm-lit.in \
>   		tools/clang/utils/hmaptool/hmaptool \
> @@ -124,7 +124,7 @@ LLDB_GH_SUBDIR=		tools/lldb:lldb
>   LLDB_GH_TAGNAME=	${LLDB_COMMIT}:lldb
>   LLDB_IMPLIES=		CLANG
>   LLDB_PORTDOCS=		lldb
> -LLDB_VARS=		_USES_PYTHON=python
> +LLDB_VARS=		_USES_PYTHON=python:3.6
>   OPENMP_DESC=		Install libomp, the LLVM OpenMP runtime library
>   OPENMP_CONFLICTS_INSTALL=	libiomp5-devel-*
>   OPENMP_GH_PROJECT=	openmp:openmp
> 

The build should explicitly specify what Python version to build with, 
to prevent autodetection/search ordering from ever playing a part

I believe this can be done by setting the CMake PYTHON_EXECUTABLE [1]

[1] CMakeLists.txt:Please install Python or specify the 
PYTHON_EXECUTABLE CMake variable.")




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7110fac2-3489-dd83-be5d-ceba196f1c51>