From owner-p4-projects  Tue Jul 30 10:32: 4 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7DCDE37B401; Tue, 30 Jul 2002 10:32:00 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1C30637B400
	for <perforce@freebsd.org>; Tue, 30 Jul 2002 10:32:00 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CDCB843E31
	for <perforce@freebsd.org>; Tue, 30 Jul 2002 10:31:59 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6UHVxJU023645
	for <perforce@freebsd.org>; Tue, 30 Jul 2002 10:31:59 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6UHVxnG023642
	for perforce@freebsd.org; Tue, 30 Jul 2002 10:31:59 -0700 (PDT)
Date: Tue, 30 Jul 2002 10:31:59 -0700 (PDT)
Message-Id: <200207301731.g6UHVxnG023642@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 15204 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=15204

Change 15204 by rwatson@rwatson_paprika on 2002/07/30 10:31:30

	Improve error reporting formatting and content.

Affected files ...

.. //depot/projects/trustedbsd/mac/usr.sbin/ugidfw/ugidfw.c#8 edit

Differences ...

==== //depot/projects/trustedbsd/mac/usr.sbin/ugidfw/ugidfw.c#8 (text+ko) ====

@@ -68,13 +68,15 @@
 
 	rule_slots = bsde_get_rule_slots(BUFSIZ, errstr);
 	if (rule_slots == -1) {
-		fprintf(stderr, errstr);
+		fprintf(stderr, "Unable to get rule slots; mac_bsdextended.ko "
+		    "may not be loaded.\n");
+		fprintf(stderr, "bsde_get_rule_slots: %s\n", errstr);
 		exit (-1);
 	}
 
 	rule_count = bsde_get_rule_count(BUFSIZ, errstr);
 	if (rule_count == -1) {
-		fprintf(stderr, errstr);
+		fprintf(stderr, "bsde_get_rule_count: %s\n", errstr);
 		exit (-1);
 	}
 
@@ -93,7 +95,8 @@
 		}
 
 		if (bsde_rule_to_string(&rule, charstr, BUFSIZ) == -1)
-			printf("oops!\n");
+			fprintf(stderr,
+			    "Unable to translate rule %d to string\n", i);
 		else
 			printf("%d %s\n", i, charstr);
 	}

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message