From owner-svn-src-all@FreeBSD.ORG Fri Dec 3 14:27:56 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A32710656A4; Fri, 3 Dec 2010 14:27:56 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id ABFF18FC08; Fri, 3 Dec 2010 14:27:55 +0000 (UTC) Received: by qyk8 with SMTP id 8so838790qyk.13 for ; Fri, 03 Dec 2010 06:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=AnLFMrz1E/EhZd/geB2qGmCnJle1edrT+GJlvt9Cabo=; b=Lb3YmOWfCwfKxCiIcS/mDi1jzRQvadfETDgXqfOEVbyADVSmRZSjOFGXHNfE1YMAEr 6ladOWucGWK9AIl4JPdFtkxKtmK6Tm+Fp9yiCiux2GwQSub9APKf7ZHakvICUjdcfRaX tL5JtDE9B/kWZwfyiZnDreSvkxZlgtn1VDRNA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=e8vV13nnJcNjLZ6XOWLobCL9gArPMyEEu00HgK9dkJMyIOTS4c4S3ERsU3Ic4pRnHI kBi4tQbSglTNJitOPRRpo9JXX0FNaQM4OfRmUVeIl0ok0MldMVRPuBdHNZPoXh1k145x pDsSynsOrwOMKmLH3hnKP3AaVuQXndWG0XT4Q= Received: by 10.229.246.136 with SMTP id ly8mr1267174qcb.237.1291386474684; Fri, 03 Dec 2010 06:27:54 -0800 (PST) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.229.231.143 with HTTP; Fri, 3 Dec 2010 06:27:13 -0800 (PST) In-Reply-To: <201012030746.44967.jhb@freebsd.org> References: <201012022219.oB2MJUx5031472@svn.freebsd.org> <20101203201705.O2228@besplex.bde.org> <20101203101651.7461ced0@core.draftnet> <201012030746.44967.jhb@freebsd.org> From: Ivan Voras Date: Fri, 3 Dec 2010 15:27:13 +0100 X-Google-Sender-Auth: oSTo9np0lDfCp2ql3lkkMX_n2BU Message-ID: To: John Baldwin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Bruce Cran , src-committers@freebsd.org, svn-src-all@freebsd.org, Bruce Evans , Bruce Cran , svn-src-head@freebsd.org Subject: Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4v... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2010 14:27:56 -0000 On 3 December 2010 13:46, John Baldwin wrote: > On Friday, December 03, 2010 5:16:51 am Bruce Cran wrote: >> On Fri, 3 Dec 2010 20:45:12 +1100 (EST) >> Bruce Evans wrote: >> >> > KASSERT() in little inline functions gives a lot of bloat for such an >> > unlikely error. =C2=A0Stupid callers can still pass any garbage count >> > except 0. >> >> Yes, this catches a specific case that hps raised a few years ago: >> sending zero-length packets/frames would fail by causing the system to >> hang. Should we just document the restriction in the man page and not >> try and prevent it at runtime? > > Documenting it is probably sufficient. I'd say it depends on if the "specific case that hps raised a few years ago" sentence part refers to an actual problem; i.e. did it happen in practice? If yes, leaving KASSERTs looks like the best option.