From owner-svn-src-head@FreeBSD.ORG Sat Dec 21 16:12:11 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BBD1C5B4; Sat, 21 Dec 2013 16:12:11 +0000 (UTC) Received: from smtpauth3.wiscmail.wisc.edu (wmauth3.doit.wisc.edu [144.92.197.226]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 817401FBA; Sat, 21 Dec 2013 16:12:11 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MY500F00YNS1N00@smtpauth3.wiscmail.wisc.edu>; Sat, 21 Dec 2013 10:12:04 -0600 (CST) X-Spam-PmxInfo: Server=avs-3, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.12.21.160315, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from wanderer.tachypleus.net (172-12-164-50.lightspeed.wlfrct.sbcglobal.net [172.12.164.50]) by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MY5001HSZO1RK20@smtpauth3.wiscmail.wisc.edu>; Sat, 21 Dec 2013 10:12:03 -0600 (CST) Message-id: <52B5BDD1.3000106@freebsd.org> Date: Sat, 21 Dec 2013 10:12:01 -0600 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 To: Devin Teske Subject: Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts References: <201312161550.rBGFox0N001344@svn.freebsd.org> <52AF2502.1060503@freebsd.org> <52B5AA94.3060009@freebsd.org> In-reply-to: X-Enigmail-Version: 1.5.2 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "Teske, Devin" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2013 16:12:11 -0000 Looks great, thanks -- although you don't need the f_quietly, which isn't defined there. The issue is that this patch very specific to running the installer on a video console. There are many circumstances in which it is not, in which case this will fail (e.g. a serial console). The other thing is that the installer should not reconfigure the host system unless it has been explicitly asked to. It isn't always run from the install media. If you think the default bindings for these keys don't make sense, then that should ultimately be fixed in the console driver as well. -Nathan On 12/21/13 10:08, Teske, Devin wrote: > I tried to rationalize... "in what case is it actually _desirably_ > that the > left or right command key _should_ generate an escape sequence > and thus cancel the existing dialog" and I couldn't think of any. > > That being said... I'm still happy to move it. Can you have a look at the > attached patch to see if matches what you envision? > > > -- > Devin > > > On Dec 21, 2013, at 6:49 AM, Nathan Whitehorn wrote: > > > Could you please revert this and move the fix to the correct place? > > -Nathan > > > > On 12/16/13 10:06, Nathan Whitehorn wrote: > >> Please add this to release/rc.local instead under the console setup. > >> There is no guarantee that "auto" is running from an environment where > >> this is defined -- for example, it may be running from a serial > >> console or an xterm -- and the actual installer should not be polluted > >> with assumptions about the media from which it runs. > >> -Nathan > >> > >> On 12/16/13 09:50, Devin Teske wrote: > >>> Author: dteske > >>> Date: Mon Dec 16 15:50:59 2013 > >>> New Revision: 259468 > >>> URL: > https://urldefense.proofpoint.com/v1/url?u=http://svnweb.freebsd.org/changeset/base/259468&k=%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=Mrjs6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=VPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3D%0A&s=aed75882069cc72d4a372f6471f113be19fcb6eeeca132b424719ac3b459e2a3 > >>> > >>> Log: > >>> Add a fix for Long-standing problem with VMware. Described in > >>> below links: > >>> > https://urldefense.proofpoint.com/v1/url?u=https://communities.vmware.com/thread/107230&k=%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=Mrjs6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=VPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3D%0A&s=eb4a25314cb93209718bd46c3a142e1a92fac348d3cdf720b26f416b6061cd17 > >>> > https://urldefense.proofpoint.com/v1/url?u=https://communities.vmware.com/docs/DOC-11677&k=%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=Mrjs6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=VPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3D%0A&s=2837df54aadfa9de8e081ac53a233ed2dc52f2f4a2be08ae75fefcdd4ee1ddbd > >>> Basically, ignore the ``function 62'' and ``function 63'' > >>> interpretations > >>> of the left/right command key when we're in the lengthiest portion > >>> of the > >>> installation (initiated by the `auto' module). > >>> The net effect is that you can now (once you've started the > >>> installer from > >>> the media) escape the VM without prematurely terminating the > >>> current action > >>> due to spurious escape sequence. > >>> MFC after: 3 days > >>> > >>> Modified: > >>> head/usr.sbin/bsdinstall/scripts/auto > >>> > >>> Modified: head/usr.sbin/bsdinstall/scripts/auto > >>> > ============================================================================== > >>> > >>> --- head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:08:30 > >>> 2013 (r259467) > >>> +++ head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:50:59 > >>> 2013 (r259468) > >>> @@ -49,6 +49,10 @@ error() { > >>> ############################################################ MAIN > >>> +# Don't send ESC on function-key 62/63 (left/right command key) > >>> +f_quietly kbdcontrol -f 62 '' > >>> +f_quietly kbdcontrol -f 63 '' > >>> + > >>> f_dprintf "Began Installation at %s" "$( date )" > >>> rm -rf $BSDINSTALL_TMPETC > >> > > > > _____________ > The information contained in this message is proprietary and/or > confidential. If you are not the intended recipient, please: (i) > delete the message and all copies; (ii) do not disclose, distribute or > use the message in any manner; and (iii) notify the sender > immediately. In addition, please be aware that any message addressed > to our domain is subject to archiving and review by persons other than > the intended recipient. Thank you.