From owner-p4-projects@FreeBSD.ORG  Mon Mar  1 12:06:02 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id AB06516A4D0; Mon,  1 Mar 2004 12:06:02 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7C06E16A4CE
	for <perforce@freebsd.org>; Mon,  1 Mar 2004 12:06:02 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 76C9C43D45
	for <perforce@freebsd.org>; Mon,  1 Mar 2004 12:06:02 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i21K62Ge052902
	for <perforce@freebsd.org>; Mon, 1 Mar 2004 12:06:02 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i21K61NN052897
	for perforce@freebsd.org; Mon, 1 Mar 2004 12:06:01 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Mon, 1 Mar 2004 12:06:01 -0800 (PST)
Message-Id: <200403012006.i21K61NN052897@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 47931 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Mar 2004 20:06:03 -0000

http://perforce.freebsd.org/chv.cgi?CH=47931

Change 47931 by rwatson@rwatson_tislabs on 2004/03/01 12:05:04

	Explicitly document semantic difference between DROP/
	PICKUP_GIANT() and NET_DROP_GIANT() and NET_PICKUP_GIANT().

Affected files ...

.. //depot/projects/netperf_socket/sys/sys/mutex.h#2 edit

Differences ...

==== //depot/projects/netperf_socket/sys/sys/mutex.h#2 (text+ko) ====

@@ -348,7 +348,10 @@
  * the Giant lock.
  *
  * This mechanism is intended as temporary until everything of
- * importance is properly locked.
+ * importance is properly locked.  Note: the semantics for
+ * NET_{PICKUP,DROP}_GIANT() are not the same as DROP_GIANT()
+ * and PICKUP_GIANT(), as they are plain mutex operations
+ * without a recursion counter.
  */
 extern	int debug_mpsafenet;		/* defined in net/netisr.c */
 #define	NET_PICKUP_GIANT() do {						\