From owner-freebsd-arch Fri Oct 5 3: 4:39 2001 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id EC8A937B405 for ; Fri, 5 Oct 2001 03:04:34 -0700 (PDT) Received: (from des@localhost) by flood.ping.uio.no (8.9.3/8.9.3) id MAA56951; Fri, 5 Oct 2001 12:04:22 +0200 (CEST) (envelope-from des@ofug.org) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Bruce Evans Cc: Peter Wemm , Subject: Re: Removing ptrace(2)'s dependency on procfs(5) References: <20011005141014.W12962-100000@delplex.bde.org> From: Dag-Erling Smorgrav Date: 05 Oct 2001 12:04:21 +0200 In-Reply-To: <20011005141014.W12962-100000@delplex.bde.org> Message-ID: Lines: 27 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans writes: > On 5 Oct 2001, Dag-Erling Smorgrav wrote: > > procfs_rwmem() was originally derived from code which still resides > > (#if 0'd out) in sys_process.c. That's why I felt it was the most > > logical place to move it to. > This may have happened before the dawn of history, but 4.4BSD-Lite has > a full procfs_rwmem() and only stubs in sys_process.c, so FreeBSD > certainly didn't derive procfs_rwmem() from sys_process.c. History > shows that sys_process.c once used pread(), but peter changed it to > use procfs in rev.1.21. It's more likely that pread() was derived > from procfs_rwmem() than vice versa. The comments in the code indicate that procfs_rwmem() was derived by merging pread() and pwrite(), not the other way around - and there are a lot of similarities between them. > This is not quite right in your reorganization. The functions are needed > by both procfs and ptrace, so they shouldn't be in procfs_machdep.c or > have names beginning with procfs. I didn't pick that location or those names. I'll move and rename these functions later, when I don't have sixty or seventy uncommitted patches in two different and partially conflicting source trees. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message