From nobody Mon Apr 17 13:45:01 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q0Swv4L3fz45vmF for ; Mon, 17 Apr 2023 13:45:19 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic303-24.consmr.mail.gq1.yahoo.com (sonic303-24.consmr.mail.gq1.yahoo.com [98.137.64.205]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q0Swt0gZMz3qXP for ; Mon, 17 Apr 2023 13:45:17 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b="GH/2UHQg"; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.205 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681739115; bh=m82l40pSy9aewkC/xNc4oiOhh2AvjDRYTytA7da+Qu0=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=GH/2UHQgHOXHXHY2WO8LAKAElGbxe3uj/lkgiL3rCCwsySqUH0heONzy8HsMahuj+04pofzv246yclM/ywcSQ+i4ED9x1iJoCM6uOzbt8oASkya519TPMzXQ2bLR9si8HUdHtprBOKV7Z0uQz4scQNm3buUIOhXW2HyPRQwe4VG51fMWWzPzsUKP1l+iu5uchJ4GD9hO8UfFzgmsDRK30U1Z7D63Q6giN2raKV8tV5CU/UuJMlukn0atn5hFVyi7CdQ24x8p3qa0XdHFXAhzILu+1RzpQvQd4vYJuFXvbCJCswbA1lxHHxcYVQfgUJI7ev4wc9mC6FAhxEhj5gv/fg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681739115; bh=WfxCAQqiwZ2g4uprMy641LUovY/3PKez4nzjwglG1hN=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=WfbF+0zD4g12W3XTTXftXl1jy0y3XNrdTzxYkAKMXn/xnznkCvDbqneBqk4leDccAbzCv4DsX/kufZbjADd1jL5NI2M9yAhI67rkEopofQDT2TMV6L2SMAzb+0ZppXdKoBpc3yVrN3OnEp8aTwr8wyBBN1uum92NbQiTyAJRmkO8cR++0QUOwpmP7QZMP+fhbl2cxMNZPLH+W+1cspYyY6jnN7t4rbWo3ihinLXOmcPiLKyriu0aojkodSIPed4csQLGnjOSdv+jQvMmqQDoIYAX1tOoHWvgsQZxTuEEgEYb+RyBIpNpyHUn7eJMZ5NPxcUX1Qn5nnYJAUKHyHXpMQ== X-YMail-OSG: IVfWDWsVM1l_G9CiOWZ9J2Ce7_jsuqJQ6wRp3RS9vVu8qoQ6nCr5ROSfi0zJAXt pBS6IsWLSOOBUubv6sO2d.4wCLB9zX3f8J90oT4syVqhQeC3S710r7cmnY0Pi.bU5V6oIpO5Nyvn SKYBkPhGwA0Kw6ncoayl75NEohmMRYsbmijcIcNlnDRzj8QXS.Cb3hYjdErSJx1nb08UcbrMkKUd 7C7UXL2rNKOHro7L_A385aa9oVslUCM9wAsuVvsfkg6FkuJqVRHg9xRzv2RgewwAuHlDOoUNvEan 1JXKQBM781f3dHi2E1bMc.hXyZjuY.Eo.15VX8K5pmdc41CxNs6GWMbRq0bUIdRRZYDSEQ7g496s PfQrXTz_Beq559n91_Jp0fUL_jsaX_iyURaeZTRt5AxYi3Xs.KsBMa_RMwYCXKVmK0b.9JOL3SCw Goh0PqPT7ZEnwVYzxZD4cRm8uIDTWy_jy.RZkh3IRQ2d5_mjXyXfhxGpEqVHxLGPIj5fHe6p.SYX 2vrDZOOBug46rf4J6CEU6.C8B3bdezQzJOQx.5KxCVj4x_kJ8tbl1nPo1jsIfd5Qi_elI3MebVCU f_Dz2dPIKScY21mqMomvj9qgJpEDENKsZB4VWZumgW1KmUzRYvxOcphLVUbsMOE2SzCWua2PN8aF 5j8WBP.d9RatzeR_KSM8LPxFePohQEd4eJHPbpkBRkLgnEOBYxqcSO0u2VouBJ7P5n_GuPoGqkIf T54aDE1sthC7PLoZ27iUy5uIQGbVFZ9ZsrGHTcIrSiRT2zyHx3csSlJljwQviSCfafeizPEt1uxt 3gn0Gr5tiTTTuamrm5PME2LJNWfUjq.C7Eo4qAO4kECOlFJDOtbkp_WAvGsZM5yWadILvwyewbu6 pSVAUZ4UiXzaH1r3VvAkXx4A.G1NuQDxRjHPZoU.uzHNGIRSIGTtGMsSI3iUx4wmTTr0Kge1C4GX VXC7_mkq0BqQ71Rw0aPHrbFUWJHYq7zZ2vbWv4VUmLIjWuLZ3UN2btZOEOSf2wXDX4FYh07_aCf2 LelzAucxlFTb0yduyYe7kbxmLgYCzHqPAu0XldgewVQXhyQP6GEZwoOJ5bYVJ9OLq6MoUJYAY1zX ev3AA_FgV1ZrY8Y94a58Klg1b9aZPw5QlquFFseG5Eph2L7wtQIZlwhHk8WuWUD4_.IqZpGjmTbD MtKYCUUbGNudJdpjECUM5mEhFNz.5FYU6.imeblxF8tiiPS7f8aiYsycNTqGW.ypEtNnPGIF9_8Y kUNFDnFRnzZyBZYJbK0fyRhMLSnki5xMuersdJYeMfTnmiP1odFkp.oQaTF9arY8PjHdG9u8VjJX jirs6i1NdK0qdH7Rc1mdXdNHHXcuOf1Ua4VP4DVCVT8XDrIY2rkQmd3xVFL4PG.mHYnpXPDTVYBC E9fte7lggZNwpSqdMmddnksM_Vnw.1qx_4gHiN2YlmYQTg.Vi.bFlNUgZYBrlorBJFB3qXOuSsTY F2nc4vVibbp2XeMjw9yo4TzH8tLVQG6WEBHtSB7kgmDzqBNUpIrDg7.R2w9PtlxAxI7eJO.b3hI8 ON_K6baeJXQ02vlUGDkV0Vp8VfkNoAtRu4UL598OAe.TzEKewxrK2FhPHmCznNvq6D11cizUhiy6 Y1rxfe6uo7RlLnzpJJ8DIrBdCpmjJG.TBA3h9g_GXyfXARkEc9Bbhgu7dv63UGbiD3jtjWf0RK0y yf70VJkOh4QSmQd3c97LRKJGdpBfT3Z7ZLU9x0NG_v1IVUpdJmABh.A3sEwSI.YVCWlPWhx32c5D ldi7bGABX0b8ICfdnrsS.EahAGAkegesqQhzqwXVn.1n5stsNZeXSx8SEMmfAKWxiDZKf599zdA. kcD5_eaV4k8oxVfYu2EqEOqiSmig0sh6tbp_Z9OIAIRXh6T4S4117E.izg7aXB5JipCRC5IzvZ1x 3FkDIACYUa1sr.73U9VKXvuySJdbuI_OBm.i9_4Qfh.IuyilLwSyrpMqM4Y3tjhsMpeV6V_Q_jhK XzChFO5RSySUO2z1MxJZ59ff7w1MMW2B8kukYQZw1kOS6ptu42QI3xtZjfnLBdf_scue7H8X9EJc p6NsYDs3fpLJR1REGRlaihnfDATll441PI8zdNLyAmIWDKMvIZkXlZYSOaPvCeLaN3aqqi7XfJEY A8RPUDwNGh9IDq4FpMXypB2IWxe1ypnQZ14iJROugwCVH8J5TzgaqgTL2SQv5Kdr_j0dslHYLizZ Dntfo7gbDTJU0eMFZ2R8HIR1jmhjpMC5mSoBrWgtxH85b19T3qggYR_EOcJJMuIqikhebeLswXJa Rs56Klw-- X-Sonic-MF: X-Sonic-ID: 1d412532-860f-40a4-a47a-addadcf09552 Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Mon, 17 Apr 2023 13:45:15 +0000 Received: by hermes--production-ne1-7dbd98dd99-gdhzk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID cff7dca568c16d032836b6d985b776c0; Mon, 17 Apr 2023 13:45:13 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Message-Id: <61987FE2-BE4E-45C5-A731-C7C6EED4D875@yahoo.com> Date: Mon, 17 Apr 2023 06:45:01 -0700 To: =?utf-8?B?Sm9zw6kgUMOpcmV6?= , Pawel Jakub Dawidek , Current FreeBSD X-Mailer: Apple Mail (2.3731.400.51.1.1) References: <61987FE2-BE4E-45C5-A731-C7C6EED4D875.ref@yahoo.com> X-Spamd-Result: default: False [-3.47 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.972]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.205:from]; TO_DN_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org] X-Rspamd-Queue-Id: 4Q0Swt0gZMz3qXP X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Jos=C3=A9_P=C3=A9rez wrote on Date: Mon, 17 Apr 2023 12:28:40 UTC : > El 2023-04-17 12:43, Pawel Jakub Dawidek escribi=C3=B3: > > On 4/17/23 18:15, Pawel Jakub Dawidek wrote: > >> There were three issues that I know of after the recent OpenZFS = merge: > >>=20 > >> 1. Data corruption unrelated to block cloning, so it can happen = even=20 > >> with block cloning disabled or not in use. This was the problematic=20= > >> commit: > >>=20 > >> = https://github.com/openzfs/zfs/commit/519851122b1703b8445ec17bc89b347cea96= 5bb9 > >>=20 > >> It was reverted in 63ee747febbf024be0aace61161241b53245449e. > >>=20 > >> 2. Data corruption with embedded blocks when block cloning is = enabled.=20 > >> It can happen when compression is enabled and the block contains=20 > >> between 60 to 112 bytes (this might be hard to determine). Fix = exists,=20 > >> it is merged to OpenZFS already, but isn't in FreeBSD yet. > >> OpenZFS pull request: https://github.com/openzfs/zfs/pull/14739 > >>=20 > >> 3. Panic on VERIFY(zil_replaying(zfsvfs->z_log, tx)). This is=20 > >> triggered when block cloning is enabled, the sync property is set = to=20 > >> disabled and copy_file_range(2) is used. Easy fix exists, it is not=20= > >> yet merged to OpenZFS and not yet in FreeBSD HEAD. > >> OpenZFS pull request: https://github.com/openzfs/zfs/pull/14758 > >>=20 > >> Block cloning was disabled in=20 > >> 46ac8f2e7d9601311eb9b3cd2fed138ff4a11a66, so 2 and 3 should not = occur. > >=20 > > As of 068913e4ba3dd9b3067056e832cefc5ed264b5cc all known issues are > > fixed, as far as I can tell. > >=20 > > Block cloning remains disabled for now just to be on the safe side, > > but can be enabled by setting sysctl vfs.zfs.bclone_enabled to 1. > >=20 > > Don't relay on this sysctl as it will be removed in 2-3 weeks. >=20 > Hi Pawel, > thank you for your reply and for the fixes. >=20 > I think there is a 4th issue that needs to be addressed: how do we=20 > recover from the worst case scenario which is a machine with a kernel = >=20 > 2a58b312b62f and ZFS root upgraded with block cloning enabled. >=20 > In particular, is it safe to turn such a machine on in the first = place,=20 > and what are the risks involved in doing so? Any potential data loss? >=20 > Would such a machine be able to fix itself by compiling a kernel, or=20= > would compilation fail and might data be corrupted in the process? >=20 > I have two poudriere builders powered off (I am not alone in this=20 > situation) and I need to recover them, ideally minimizing data loss. = The=20 > builders are also hosting current and used to build kernels and worlds=20= > for 13 and current: as of now all my production machines are stuck on=20= > the 13 they run, I cannot update binaries nor packages and I would = like=20 > to be back online. >=20 > Whatever the fixing procedure, it shall be outlined in the UPDATING=20 > document. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270811 is an example issue where a FreeBSD powerpc package building server can not boot --after patching so it no longer gets a boot time "panic: floating-point unavailable trap" (that jhibbits patch is still not committed): QUOTE from the description: . . . nda1: 953869MB (1953525168 512 byte sectors) GEOM_MIRROR: Device mirror/swap0 launched (2/2). Mounting from zfs:zroot failed with error 6; retrying for 3 more seconds Mounting from zfs:zroot failed with error 6. Loader variables: vfs.root.mountfrom=3Dzfs:zroot Manual root filesystem specification: : [options] Mount using filesystem and with the specified (optional) option list. eg. ufs:/dev/da0s1a zfs:zroot/ROOT/default cd9660:/dev/cd0 ro (which is equivalent to: mount -t cd9660 -o ro /dev/cd0 /) ? List valid disk boot devices . Yield 1 second (for background tasks) Abort manual input mountroot> This machine is part of the FreeBSD cluster for building PowerPC = packages, so we can build kernels to test anytime necessary. END QUOTE =3D=3D=3D Mark Millard marklmi at yahoo.com