From owner-dev-commits-src-all@freebsd.org Fri Apr 9 21:21:07 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B16065BDA77; Fri, 9 Apr 2021 21:21:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FH9zR3YzTz4dk4; Fri, 9 Apr 2021 21:21:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4FAC124E7B; Fri, 9 Apr 2021 21:21:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 139LL7WW021668; Fri, 9 Apr 2021 21:21:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 139LL7sO021667; Fri, 9 Apr 2021 21:21:07 GMT (envelope-from git) Date: Fri, 9 Apr 2021 21:21:07 GMT Message-Id: <202104092121.139LL7sO021667@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 7c71f3bd6ace - main - tcp_hostcache: remove extraneous check. All paths leading here already checked this setting. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7c71f3bd6acea654b3fc6fdb44f30e8ea601b422 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2021 21:21:07 -0000 The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=7c71f3bd6acea654b3fc6fdb44f30e8ea601b422 commit 7c71f3bd6acea654b3fc6fdb44f30e8ea601b422 Author: Gleb Smirnoff AuthorDate: 2021-04-08 21:17:39 +0000 Commit: Gleb Smirnoff CommitDate: 2021-04-09 21:07:19 +0000 tcp_hostcache: remove extraneous check. All paths leading here already checked this setting. Reviewed by: rscheff --- sys/netinet/tcp_hostcache.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sys/netinet/tcp_hostcache.c b/sys/netinet/tcp_hostcache.c index 130b08425096..300cbafe4bcd 100644 --- a/sys/netinet/tcp_hostcache.c +++ b/sys/netinet/tcp_hostcache.c @@ -325,9 +325,6 @@ tcp_hc_lookup(struct in_conninfo *inc, bool update) struct hc_head *hc_head; struct hc_metrics *hc_entry; - if (!V_tcp_use_hostcache) - return NULL; - KASSERT(inc != NULL, ("tcp_hc_lookup with NULL in_conninfo pointer")); /* @@ -395,9 +392,6 @@ tcp_hc_insert(struct in_conninfo *inc) struct hc_head *hc_head; struct hc_metrics *hc_entry; - if (!V_tcp_use_hostcache) - return NULL; - KASSERT(inc != NULL, ("tcp_hc_insert with NULL in_conninfo pointer")); /*