From owner-cvs-src-old@FreeBSD.ORG  Mon Oct 27 14:01:37 2008
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 90397106566C
	for <cvs-src-old@freebsd.org>; Mon, 27 Oct 2008 14:01:37 +0000 (UTC)
	(envelope-from rrs@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7DFFE8FC2B
	for <cvs-src-old@freebsd.org>; Mon, 27 Oct 2008 14:01:37 +0000 (UTC)
	(envelope-from rrs@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m9RE1bae012112
	for <cvs-src-old@freebsd.org>; Mon, 27 Oct 2008 14:01:37 GMT
	(envelope-from rrs@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m9RE1bQB012111
	for cvs-src-old@freebsd.org; Mon, 27 Oct 2008 14:01:37 GMT
	(envelope-from rrs@repoman.freebsd.org)
Message-Id: <200810271401.m9RE1bQB012111@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	rrs@repoman.freebsd.org using -f
From: Randall Stewart <rrs@FreeBSD.org>
Date: Mon, 27 Oct 2008 14:01:23 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/netinet sctp_output.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2008 14:01:37 -0000

rrs         2008-10-27 14:01:23 UTC

  FreeBSD src repository

  Modified files:
    sys/netinet          sctp_output.c 
  Log:
  SVN rev 184336 on 2008-10-27 14:01:23Z by rrs
  
  Two inter-related bugs.
    - If we send EXACTLY the size left in the send buffer
      and then send again, we end up with exactly 0 bytes and
      don't hit the pre-block code to wait for more space.
    - If we fall into the loop with our max_len == 0 (the bug
      above) we then call in to copy out the data, setup the length
      of the waiting to transmit data to 0 and call the mbuf copy routine
      which 0 indicates copy all the data to the mbuf chain.. which it
      does. This then leaves a "stuck" message on the stream queue with
      its size exactly 0 bytes but all the data there and thus nothing
      left in the uio structure. We then reach a stuck forever state
      never being able to send data.
  
  Revision  Changes    Path
  1.78      +8 -2      src/sys/netinet/sctp_output.c