From owner-svn-src-all@freebsd.org Fri Apr 5 14:47:21 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3DCA157921C; Fri, 5 Apr 2019 14:47:21 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au [211.29.132.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4BFD994AE6; Fri, 5 Apr 2019 14:47:20 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 34CCD3DC95D; Sat, 6 Apr 2019 01:47:17 +1100 (AEDT) Date: Sat, 6 Apr 2019 01:47:15 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Ed Maste cc: "Rodney W. Grimes" , Xin LI , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs In-Reply-To: Message-ID: <20190406014249.N4174@besplex.bde.org> References: <201904050221.x352LGjU015040@repo.freebsd.org> <201904050449.x354nUEC036896@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=FNpr/6gs c=1 sm=1 tr=0 cx=a_idp_d a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=iKhvJSA4AAAA:8 a=6rpjA9K-Bi6h7L4oEakA:9 a=CjuIK1q_8ugA:10 a=odh9cflL3HIXMm4fY7Wr:22 X-Rspamd-Queue-Id: 4BFD994AE6 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.944,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 14:47:22 -0000 On Fri, 5 Apr 2019, Ed Maste wrote: > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: >> > >>> +static const u_char dot_name[] = { >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; >>> +static const u_char dotdot_name[] = { >>> + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; >>> + >> >> Does it make since to encode these as hex or octal constants, >> one can not tell that those are different values in an easy >> manner. They all look like '.' in the diff, and probably >> in most editors. No, but it makes sense to write them as string constants. They are just the strings "." and ".." padded with spaces to length 11, except they are not actually strings since they are not NUL terminated. 11 is for 8+3 msdos short file names. These are not NUL terminated either, but it should be easy to ignore the extra NUL given by the string constants. > They are all either '.' or ' ', the commas are just list separators. > IMO spaces after the commas would make it slightly easier to see. The single quotes looking like commas indeed makes this hard to read. Bruce