From owner-freebsd-net Wed Feb 14 8: 0:52 2001 Delivered-To: freebsd-net@freebsd.org Received: from garm.bart.nl (garm.bart.nl [194.158.170.13]) by hub.freebsd.org (Postfix) with ESMTP id 7364737B401 for ; Wed, 14 Feb 2001 08:00:49 -0800 (PST) Received: from daemon.chronias.ninth-circle.org (root@cable.ninth-circle.org [195.38.232.6]) by garm.bart.nl (8.10.1/8.10.1) with ESMTP id f1EG0i522876; Wed, 14 Feb 2001 17:00:44 +0100 (CET) Received: (from asmodai@localhost) by daemon.chronias.ninth-circle.org (8.11.1/8.11.0) id f1EFio433027; Wed, 14 Feb 2001 16:44:50 +0100 (CET) (envelope-from asmodai) Date: Wed, 14 Feb 2001 16:44:49 +0100 From: Jeroen Ruigrok/Asmodai To: Luigi Rizzo Cc: net@freebsd.org Subject: Re: dead code in ip_output.c and udp_var.h Message-ID: <20010214164449.A32946@daemon.ninth-circle.org> References: <200102090046.f190k6K06283@iguana.aciri.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <200102090046.f190k6K06283@iguana.aciri.org>; from rizzo@aciri.org on Thu, Feb 08, 2001 at 04:46:06PM -0800 Organisation: Ninth-Circle Enterprises Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org -On [20010209 02:00], Luigi Rizzo (rizzo@aciri.org) wrote: >and maybe it would be the case to remove the first block and the >conditionals on the second one. I don't think we plan a port to the >vax, am i wrong ? Personally I'd be happier if this got removed. We don't intend to port to VAX, and the only thing I can think of is that it might make diffing a bit easier, which is a mootpoint anyway nowadays with SMPng touching the whole of the kernel. So, I'd ACK that. I am personally pondering to removal hacks like this from the telnet(d) synching I am doing. >udp_var.h contains a definition of "struct udpcb" and "inptoudpcb()" >which are never used anywhere. Again if there are no objections i >would like to nuke them. I only see a reference to udpcb in udp_usrreq.c, but that's a zinit() label name. So you have my ACK. Not sure what wollman or jlemon think? ACK on the inptudpcb() removal. -- Jeroen Ruigrok vd Werven/Asmodai asmodai@[wxs.nl|bart.nl|freebsd.org] Documentation nutter/C-rated Coder BSD: Technical excellence at its best D78D D0AD 244D 1D12 C9CA 7152 035C 1138 546A B867 I'm a child of the air, I'm a witch of the wind... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message