From owner-svn-src-head@FreeBSD.ORG Sat Mar 13 13:51:02 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51F881065673; Sat, 13 Mar 2010 13:51:02 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from lakerest.net (unknown [IPv6:2001:240:585:2:213:d4ff:fef3:2d8d]) by mx1.freebsd.org (Postfix) with ESMTP id D57EB8FC19; Sat, 13 Mar 2010 13:51:01 +0000 (UTC) Received: from [10.10.1.82] (s224.GtokyoFL6.vectant.ne.jp [222.228.90.224]) (authenticated bits=0) by lakerest.net (8.14.3/8.14.3) with ESMTP id o2DDovsJ059939 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sat, 13 Mar 2010 08:51:00 -0500 (EST) (envelope-from rrs@lakerest.net) Message-Id: <2F4A2F84-4955-49C2-B25E-BB987BC27815@lakerest.net> From: Randall Stewart To: Robert Watson In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Date: Sat, 13 Mar 2010 22:50:56 +0900 References: <201003122258.o2CMwqDM039077@svn.freebsd.org> X-Mailer: Apple Mail (2.936) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r205104 - in head/sys: dev/xen/netback netinet netinet6 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2010 13:51:02 -0000 Hmm. did not think of that.. we COULD possible do it another way.. a bit harder but possible.. i.e. have the delayed sack code actually look into the mbufs and see if its ipv4 or ipv6.. I thought about doing it that way but it takes more cycles ;-o I could refactor that this way if you want... it would mean a few more de-ref's and looking to see if its a v4 or v6 packet and then doing the proper offset... not to bad but awkward ;-0 R On Mar 13, 2010, at 9:58 PM, Robert Watson wrote: > > On Fri, 12 Mar 2010, Randall Stewart wrote: > >> The proper fix for the delayed SCTP checksum is to >> have the delayed function take an argument as to the offset >> to the SCTP header. This allows it to work for V4 and V6. >> This of course means changing all callers of the function >> to either pass the header len, if they have it, or create >> it (ip_hl << 2 or sizeof(ip6_hdr)). > > It will become harder to MFC SCTP changes like this in the future, > BTW. It's only good (bad) luck that this change doesn't break the > KBI depended on by the ipdivert module. If SCTP had been enabled in > the module (which it probably should be, with options SCTP in > GENERIC), then the module would be broken, meaning that we couldn't > MFC this change as-is. > > After MFCing this change, I recommend fixing ipdivert, but also > increased caution in changing kernel interfaces that may be depended > on by modules... > > Robert N M Watson > Computer Laboratory > University of Cambridge > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)