From nobody Sun Jul 19 13:42:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h34bZ39Sjz6mDpJ for ; Sun, 19 Jul 2026 13:43:06 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h34bZ0zPMz3flF for ; Sun, 19 Jul 2026 13:43:06 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4954f5e8020so5654025e9.2 for ; Sun, 19 Jul 2026 06:43:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784468580; x=1785073380; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LW0ivhAX7SQ7nZVz4v3z0Kz8Iy5TeIXDmTWQKdiyFI0=; b=N0VKiOiXYU5BLXs5JUZv/CC2vpsCnnqhEhRWKq5NL2eUqozkXYPYNrsK2Lskz1rZWc roRdbZ3SlLnmx3ew4hTo3oIPxucCcn/5DrpFWNHmlS7u9P2yzba5zeJzp5NNo5aBWlzz ma9XUSRTpw7vFsL92JFEe3f579mI8WXRr+8W/QK9J4tvgyMOeQaKDSOHAYyVKp2ci2Q+ PVreDwPmUYfqp819ymSzONWLZux9fnT/GR1EEIU4aDAxloo2LUw6EBl3RmrG10OF8Ep3 fj3NbjqMKjAu2Xof7Clkk+Y+OealMNxmhv7+5rE7jrc7SZ6Cgnv2wj4Pjds06pivER/y jHqg== X-Forwarded-Encrypted: i=1; AHgh+Rq5ppMOL408HEnfpRAZXL6EM6pOuZMQVnicY9QnhGTKCha3h8QkkLrjB1EEJ8bebta5qxhyvbem8NfECQ7DGjsTwuml@freebsd.org X-Gm-Message-State: AOJu0YxJoPP6qMXqhiXElT+E/ALeGFL7YwytCxX8RzN/5Ey+WN7iaMYd xpWDyYpHZFcd6vSQQ4qOlo/eHp5qzJTOwbF53LsSJqpeO/r+t4SLTwj2LNKmf/GTInCeBY25ITX bo2H3R9I= X-Gm-Gg: AfdE7cktcul2DO/ohZi8FW3fAeGOZS22CTzfQIHofF6FsTHCfeWqk9lNyr/zJFfH13w RnEVy9XQsrcdBcJAUl1vKW0YFPEuLjAUPnCzqMsGaOasl+PT1/Pw/pm1N2cyZH+MUjkKGxdnUq8 B1gsjOyVcMfsGTM8cMpsbGE0vFH7CSK1lftN/cBPsWamijLMG91ZN4dxpKe5gJ1mKJ2lBRdpPBF nrKhPvh4YR6TwfH5psTZEuLD1yyz+RhUsRXTn+ICquBGsXEGgZa4kOydY9pUKWyz0TGNPQHrTaU G8GCi+RZpk8ILGMh4g/eibqz0ox2VgKN1Ew7kmhIyJVrNYeC8vjGs8zL+RaBDUAhrHaxdycvfxG MZ7uCp7bJP3y4JnbB3t0bzd7fNZwkpphDo7D2Cra/Cs7Kq8Ek9LmpibJxafqxbBqnbtt0fE/Pd/ GuTsAmEZNc+pRcy7QPOPqHfdMy+1PgTRO1iCW+de1lXG073AtY X-Received: by 2002:a05:600c:4f86:b0:495:3e81:76fa with SMTP id 5b1f17b1804b1-4954e1e065cmr83275455e9.15.1784468579131; Sun, 19 Jul 2026 06:42:59 -0700 (PDT) Received: from smtpclient.apple (nat-184-161.net.cam.ac.uk. [131.111.184.161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63e49acesm19783197f8f.6.2026.07.19.06.42.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jul 2026 06:42:58 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3893.100.7.1.1\)) Subject: Re: git: bdc0f7678257 - main - hwpstate_intel: Fix i386 build From: Jessica Clarke In-Reply-To: Date: Sun, 19 Jul 2026 14:42:47 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Harry Schmalzb Content-Transfer-Encoding: quoted-printable Message-Id: <8A47C3A1-E9FD-45D4-9547-3624CF482445@freebsd.org> References: <6a5cd2fb.3bcc6.f82cb9f@gitrepo.freebsd.org> To: ShengYi Hung X-Mailer: Apple Mail (2.3893.100.7.1.1) X-Spamd-Result: default: False [-2.37 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.966]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; TO_DN_SOME(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.45:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.45:from]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4h34bZ0zPMz3flF X-Spamd-Bar: -- On 19 Jul 2026, at 14:40, Jessica Clarke wrote: >=20 > On 19 Jul 2026, at 14:36, ShengYi Hung wrote: >>=20 >> The branch main has been updated by aokblast: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dbdc0f7678257eaa739b9c81628550447= 0e71e3de >>=20 >> commit bdc0f7678257eaa739b9c816285504470e71e3de >> Author: Harry Schmalzb >> AuthorDate: 2026-07-13 05:29:34 +0000 >> Commit: ShengYi Hung >> CommitDate: 2026-07-19 13:36:00 +0000 >>=20 >> hwpstate_intel: Fix i386 build >>=20 >> Reviewed by: olce >> Fixes: 7b26353a59d6 >> MFC after: 3 days >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D58208 >> --- >> sys/x86/cpufreq/hwpstate_intel.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >>=20 >> diff --git a/sys/x86/cpufreq/hwpstate_intel.c = b/sys/x86/cpufreq/hwpstate_intel.c >> index 59d7a155fda8..56a33fa88e66 100644 >> --- a/sys/x86/cpufreq/hwpstate_intel.c >> +++ b/sys/x86/cpufreq/hwpstate_intel.c >> @@ -352,13 +352,19 @@ intel_hwpstate_hybrid_cb(void *ctx) >> { >> uint32_t *small_cores =3D ctx; >>=20 >> +#ifdef __i386__ >> + (void)small_cores; >> +#else >> atomic_add_32(small_cores, PCPU_GET(small_core)); >> +#endif >> } >=20 > Hi, > The whole point of my suggestion was that this would be the only part > of the diff needed. By stubbing out the function, small_cores is never > incremented, and so the code ifndef=E2=80=99ed out below is dead = without the > need for as many ifndefs. (And if that doesn=E2=80=99t work then you should go back to your = original diff. But this version here is the worst of both worlds, since now intel_hwpstate_hybrid_cb is an unused static function, I believe.)=