From owner-svn-src-all@freebsd.org Sat Oct 24 13:38:21 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 46535449DC6; Sat, 24 Oct 2020 13:38:21 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward501j.mail.yandex.net (forward501j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CJMcW5QdWz4ZNZ; Sat, 24 Oct 2020 13:38:19 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from mxback8g.mail.yandex.net (mxback8g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:169]) by forward501j.mail.yandex.net (Yandex) with ESMTP id 8FB94338016C; Sat, 24 Oct 2020 16:38:14 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback8g.mail.yandex.net (mxback/Yandex) with ESMTP id Jw6UX2hoTg-cDpeMpZx; Sat, 24 Oct 2020 16:38:13 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1603546693; bh=3QA//zdEhZE5MD4I1wkxXVEw32ck/3SNpF+wV96sM5A=; h=Message-Id:Cc:Subject:In-Reply-To:Date:References:To:From; b=R4rPs8b3TCoEtNehsnSxgfh9ref857kzIXCBpLLEAKgl3R2OVs3+KlqrdkAqRTtNx apEXRxtxPvSzsoVjN6uf3EzDRj/jw1G3hGxc9YCeccNcI2ZJCQBtGOt+v7mfbUYrnj zX90+oc16GQIO6CtWG+4f+1KxRA6ipzg9cXXpwMA= Received: by sas1-ffdbcd5f1d77.qloud-c.yandex.net with HTTP; Sat, 24 Oct 2020 16:38:12 +0300 From: Alexander V. Chernikov To: Hans Petter Selasky , Alexey Dokuchaev Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" In-Reply-To: <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org> References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org> <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org> Subject: Re: svn commit: r366993 - head/sys/net MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sat, 24 Oct 2020 14:38:12 +0100 Message-Id: <317231603546378@mail.yandex.ru> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 4CJMcW5QdWz4ZNZ X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ipfw.ru header.s=mail header.b=R4rPs8b3; dmarc=none; spf=pass (mx1.freebsd.org: domain of melifaro@ipfw.ru designates 2a02:6b8:0:801:2::111 as permitted sender) smtp.mailfrom=melifaro@ipfw.ru X-Spamd-Result: default: False [-3.90 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[ipfw.ru:s=mail]; FREEFALL_USER(0.00)[melifaro]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a02:6b8:0::/52]; NEURAL_HAM_LONG(-0.96)[-0.956]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[ipfw.ru]; NEURAL_HAM_MEDIUM(-1.09)[-1.089]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[ipfw.ru:+]; NEURAL_HAM_SHORT(-1.26)[-1.258]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13238, ipnet:2a02:6b8::/32, country:RU]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; RCVD_IN_DNSWL_LOW(-0.10)[2a02:6b8:0:801:2::111:from] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2020 13:38:21 -0000 24.10.2020, 14:08, "Hans Petter Selasky" : > On 2020-10-24 14:52, Alexey Dokuchaev wrote: >>  On Sat, Oct 24, 2020 at 10:23:22AM +0000, Hans Petter Selasky wrote: >>>  New Revision: 366993 >>>  URL: https://svnweb.freebsd.org/changeset/base/366993 >>> >>>  Log: >>>     Run code through "clang-format -style=file" with some additional fixes. >>>     No functional change. >>> >>>  ... >>>  @@ -99,8 +97,8 @@ infiniband_ipv4_multicast_map(uint32_t addr, >>> >>>    #ifdef INET6 >>>    static inline void >>>  -infiniband_ipv6_multicast_map(const struct in6_addr *addr, >>>  - const uint8_t *broadcast, uint8_t *buf) >>>  +infiniband_ipv6_multicast_map( >>>  + const struct in6_addr *addr, const uint8_t *broadcast, uint8_t *buf) >>>    { >> >>  This is not how we format these in FreeBSD, please revert. It was correct >>  before and no "fix" is need here. Given we already have nice .clang-format, that does most of the job, maybe it's worth considering looking into tweaking it further to fix this part? It would be nice if we could finally offload all formatting issues to the tool and focus on the actual code :-) > Done. > > --HPS