Date: Sat, 24 Oct 2020 14:38:12 +0100 From: Alexander V. Chernikov <melifaro@ipfw.ru> To: Hans Petter Selasky <hps@selasky.org>, Alexey Dokuchaev <danfe@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r366993 - head/sys/net Message-ID: <317231603546378@mail.yandex.ru> In-Reply-To: <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org> References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org> <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
24.10.2020, 14:08, "Hans Petter Selasky" <hps@selasky.org>: > On 2020-10-24 14:52, Alexey Dokuchaev wrote: >> On Sat, Oct 24, 2020 at 10:23:22AM +0000, Hans Petter Selasky wrote: >>> New Revision: 366993 >>> URL: https://svnweb.freebsd.org/changeset/base/366993 >>> >>> Log: >>> Run code through "clang-format -style=file" with some additional fixes. >>> No functional change. >>> >>> ... >>> @@ -99,8 +97,8 @@ infiniband_ipv4_multicast_map(uint32_t addr, >>> >>> #ifdef INET6 >>> static inline void >>> -infiniband_ipv6_multicast_map(const struct in6_addr *addr, >>> - const uint8_t *broadcast, uint8_t *buf) >>> +infiniband_ipv6_multicast_map( >>> + const struct in6_addr *addr, const uint8_t *broadcast, uint8_t *buf) >>> { >> >> This is not how we format these in FreeBSD, please revert. It was correct >> before and no "fix" is need here. Given we already have nice .clang-format, that does most of the job, maybe it's worth considering looking into tweaking it further to fix this part? It would be nice if we could finally offload all formatting issues to the tool and focus on the actual code :-) > Done. > > --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?317231603546378>