From owner-svn-ports-all@FreeBSD.ORG Mon Oct 21 23:39:21 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B8327EA6 for ; Mon, 21 Oct 2013 23:39:21 +0000 (UTC) (envelope-from pgollucci@p6m7g8.com) Received: from mail-ie0-f175.google.com (mail-ie0-f175.google.com [209.85.223.175]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 845B42F48 for ; Mon, 21 Oct 2013 23:39:21 +0000 (UTC) Received: by mail-ie0-f175.google.com with SMTP id aq17so406006iec.34 for ; Mon, 21 Oct 2013 16:39:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=3uFYZ/eSWN6YrQldrN+UrWVDCeromMPk1aqqaKqjzCE=; b=M3g99BLIb7lpG3csXU8ID/xVO2DjvYIMuvD7chWtlBmK343oHhkEeSoCq45GM5qUkH dha9BH4EXC7qE5kyBbcRZW2tMkXZBA1WCnAHjNj+6rBuDviehbHOBj4TC6fLe1S8lA/3 wNKgIqihUDKZFuLj7cKaeBZsZ88GwxHzR94vFF2xV697FcwZ4ykcuWgd5vkcHcAzRu10 tISEkR5ufTmdb297+8WIbuJ6VClKKtU+rsd3xRe7VbxvGMSONTzF124b6atxqdgwVuiy nxxM1GMA002un4e9WiobrTH+3iv2MXQ7gHHfvZ6QmHfkj1Ez58RfH+EmCzkN4NxtMYhg dDAg== X-Gm-Message-State: ALoCoQlNA88AP7ziuwUl0lePWILlH48CT+ubl7i+B4v6KS1SlEFZlptgWMFW47pXqsP1NDfnFeBd MIME-Version: 1.0 X-Received: by 10.42.27.82 with SMTP id i18mr379701icc.29.1382398755349; Mon, 21 Oct 2013 16:39:15 -0700 (PDT) Received: by 10.50.39.46 with HTTP; Mon, 21 Oct 2013 16:39:15 -0700 (PDT) X-Originating-IP: [199.108.71.41] In-Reply-To: References: <201310201812.r9KICnwq080041@svn.freebsd.org> <20131021064704.GA29510@ithaqua.etoilebsd.net> Date: Mon, 21 Oct 2013 19:39:15 -0400 Message-ID: Subject: Re: svn commit: r331046 - head/Mk/Scripts From: "Philip M. Gollucci" To: Eitan Adler Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , Baptiste Daroussin , "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , Alex Kozlov X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Oct 2013 23:39:21 -0000 +10,000 ! On Mon, Oct 21, 2013 at 9:41 AM, Eitan Adler wrote: > On Mon, Oct 21, 2013 at 2:47 AM, Baptiste Daroussin > wrote: > > On Sun, Oct 20, 2013 at 03:01:38PM -0400, Eitan Adler wrote: > >> On Sun, Oct 20, 2013 at 2:12 PM, Alex Kozlov wrote: > >> > Author: ak > >> > Date: Sun Oct 20 18:12:49 2013 > >> > New Revision: 331046 > >> > URL: http://svnweb.freebsd.org/changeset/ports/331046 > >> > > >> > Log: > >> > - Add check for suid files and directories > >> > >> Can you please add an in-port variable to disable this (NEEDS_SUID / > >> NEEDS_ROOT) or remove this check? > >> > >> Warnings which may be ignored are not very useful. > >> > > > > I do not think this is really a good way. First NEED_ROOT is a temporary > knob > > and should die as soon a possible as everything should be doable as a > user. > > As I said to Alex privately, > > it should be possible to run check-sanity across the tree and get > *zero* results. If some warnings could be ignored people will start > ignoring all of them or people will start to "fix" them incorrectly. > Look at what happens with portlint warnings. > > There needs to be an in-port method of quieting bogus warnings. > > > -- > Eitan Adler > Source, Ports, Doc committer > Bugmeister, Ports Security teams > -- --------------------------------------------------------------------------------------------- 4096R/D1EAB94D 2081 E230 3001 6508 8847 1BBF A0A8 DB0F D1EA B94D Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Director IT Operations, RideCharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching.