Date: Wed, 12 Dec 2018 18:13:57 +0000 (UTC) From: Conrad Meyer <cem@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r341994 - head/sys/geom/mirror Message-ID: <201812121813.wBCIDvjH088022@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: cem Date: Wed Dec 12 18:13:56 2018 New Revision: 341994 URL: https://svnweb.freebsd.org/changeset/base/341994 Log: gmirror: Remove a last-minute INVARIANTS breakage in r341840 I mistakenly added a lock assertion to this routine at the last minute without confirming it was held during g_mirror_create. It isn't (it isn't even initialized yet). Mea culpa. Access is exclusive in both callers, just not always by that particular lock. Reported by: lwhsu X-MFC-With: r341840, r341674 Modified: head/sys/geom/mirror/g_mirror.c Modified: head/sys/geom/mirror/g_mirror.c ============================================================================== --- head/sys/geom/mirror/g_mirror.c Wed Dec 12 17:05:47 2018 (r341993) +++ head/sys/geom/mirror/g_mirror.c Wed Dec 12 18:13:56 2018 (r341994) @@ -3061,8 +3061,6 @@ g_mirror_reinit_from_metadata(struct g_mirror_softc *s const struct g_mirror_metadata *md) { - sx_assert(&sc->sc_lock, SX_XLOCKED); - sc->sc_genid = md->md_genid; sc->sc_syncid = md->md_syncid;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812121813.wBCIDvjH088022>