From nobody Wed Feb 11 20:41:29 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fB9MF66QTz6SBN6 for ; Wed, 11 Feb 2026 20:41:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fB9MF3zb0z3MR0 for ; Wed, 11 Feb 2026 20:41:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770842489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GqkYwTu3xfD7BLhdzFTDC6sMz+wiv1xfG0zjnjfAT+A=; b=DKdDwundvJCQlZAaJcG0y+/drVMiyuXjPsgQFM+UhmLmV2F41RiB4bnx3W/hdxvzzsuhY8 bBuk/Ha/EHChLPIZfQ/zxlSRVRrRW0vl02uoVn9NQBfGS6cbCkIUVEL/NR1cUL0hr9xKoW 5PzehIOim/QXwrgqjjSqcJzLqyfzUlNZadFiGt10i7L6lmnPIRufLWe1g1fCWCVf3JpOQd wbrBE1z1ej7AlQm+D8/Nr3HHl0EoHA2YbqepueQUo+Vjm3z5MQPcd34cqqHUtL9Mq71Fdm JfxR3AuBGt40Eb+emcPtWdaDe4EcbbRyQefnwXdP2OhuzsENAQ2mTA+aCWxxcw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770842489; a=rsa-sha256; cv=none; b=bh0crW6KvzNzZvQJly4hVAjEzZ7nC2xlsYpctdn3CWnWGM7GyF6jjzoZ7z0ENirxnE9A1e 9Ab++/fTk+4Un8tjmlI4spjfdYUtMBLhbLUEKrpQx3OwC10n6cFCLMDAhSD/pTDFMuI4Dg 7GA4nVyOsIsYCvFpcU8faKMqjuhbTZDKDob4R1f9Kb0XPb2X6SEeJ1/PrzBobtpz8rr/Kb MfGldKNwawLXQqZ7O0Y1gwQOhUvyddrX5PvLn+agTmIacS0L4C0MwUUnWG5dBApvWTv+j+ chdHTC1FZsDym3GdekgsCWu1rKlvoaSPImPeDuI61aJaPddlrl1WjUJYXWcdVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770842489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GqkYwTu3xfD7BLhdzFTDC6sMz+wiv1xfG0zjnjfAT+A=; b=BlpNHZwEKIBCebELFGMM+gBdtO4vOml+M3fteYb28qRaZC/Dh1ysu1bARSsFCJYCSWhpEJ AbiwFbXkvKfkDRxCsWLUWYBQWugq/73/HX+XXZZRJFpxryZy5UiAcVo1O0Kerqh4wRPXOB zz5/JxUCvZGI1G0WQTdD48B2VBtbBPomIO2hObQzIxr1mT6TdBGCp70dpKnFt6ga4pkxkQ IgvayigjsbBfX+SOj6lkfxOc9PqBiVHBWMHzmz/0S5u8nv4Lxagb2gvej9n1fwlmMbekyo jNGAxNdzgpf/p8usXUEDbMdlnWshmohnIV4TdRqLn/7jJXxFHos7YUqyLd/fyw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fB9MF3XZYz14d4 for ; Wed, 11 Feb 2026 20:41:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4779f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 20:41:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 4781aeb5b9cb - stable/14 - libfetch: Check for failure to create SSL context List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 4781aeb5b9cb564a53fee8128f6827402deaf9df Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 20:41:29 +0000 Message-Id: <698ce979.4779f.3cdbead5@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=4781aeb5b9cb564a53fee8128f6827402deaf9df commit 4781aeb5b9cb564a53fee8128f6827402deaf9df Author: Dag-Erling Smørgrav AuthorDate: 2026-02-07 14:24:40 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-11 13:54:41 +0000 libfetch: Check for failure to create SSL context * Drop the ssl_meth member, there is no reason to hang on to it. * Replace deprecated SSLv23_client_method() with TLS_client_method(). * Check the return value from SSL_CTX_new(). MFC after: 1 week PR: 292903 Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55098 (cherry picked from commit 4e160c6197f75fda3d5d5997ce893087058cf718) --- lib/libfetch/common.c | 10 +++++++--- lib/libfetch/common.h | 1 - 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/libfetch/common.c b/lib/libfetch/common.c index a39bfb33e95c..d5423d8eb5d1 100644 --- a/lib/libfetch/common.c +++ b/lib/libfetch/common.c @@ -1183,8 +1183,11 @@ fetch_ssl(conn_t *conn, const struct url *URL, int verbose) X509_NAME *name; char *str; - conn->ssl_meth = SSLv23_client_method(); - conn->ssl_ctx = SSL_CTX_new(conn->ssl_meth); + if ((conn->ssl_ctx = SSL_CTX_new(TLS_client_method())) == NULL) { + fprintf(stderr, "SSL context creation failed\n"); + ERR_print_errors_fp(stderr); + return (-1); + } SSL_CTX_set_mode(conn->ssl_ctx, SSL_MODE_AUTO_RETRY); fetch_ssl_setup_transport_layer(conn->ssl_ctx, verbose); @@ -1195,7 +1198,8 @@ fetch_ssl(conn_t *conn, const struct url *URL, int verbose) conn->ssl = SSL_new(conn->ssl_ctx); if (conn->ssl == NULL) { - fprintf(stderr, "SSL context creation failed\n"); + fprintf(stderr, "SSL connection creation failed\n"); + ERR_print_errors_fp(stderr); return (-1); } SSL_set_fd(conn->ssl, conn->sd); diff --git a/lib/libfetch/common.h b/lib/libfetch/common.h index 7396c8a68ab6..06089aae5451 100644 --- a/lib/libfetch/common.h +++ b/lib/libfetch/common.h @@ -56,7 +56,6 @@ struct fetchconn { SSL *ssl; /* SSL handle */ SSL_CTX *ssl_ctx; /* SSL context */ X509 *ssl_cert; /* server certificate */ - const SSL_METHOD *ssl_meth; /* SSL method */ #endif int ref; /* reference count */ };