From owner-dev-commits-src-all@freebsd.org Thu Mar 11 17:39:08 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 760AC57C559; Thu, 11 Mar 2021 17:39:08 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DxGQh2fMFz3NVs; Thu, 11 Mar 2021 17:39:08 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1615484348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hvpy29zrpEBk7JkeqnvMCTxdSrnsaJ21NlReM2R8SBE=; b=jCFap4bdmpWqUABJeFtlHPYTawzhUCbLkOZSgAAb2OWBaGdHHPGVJDMhp1jPgS+i9oCksZ HTBnMK1Qsvpx7pb+/MLaaFWWboe79xnsaKZQUc273iYcGWkQajjiGBoPwsjtSatUssTPWy N1zy82601a2AcHRACXS49zcOL71KtHH8k3VsaDvJGeVaVn8xSivlxoQvoBYa8cGSUYvfr7 vvC5jKCWFOoB1q+ktnkkgSM3VttHS3n6fPbSE7Pxg8TZCZpnCQhfWkNInMVUpYsTFPmUyF THRUSWwg1w0BihX8PeqYUFmJ5BZtawyJUX2mu7FmDLYbOTjSkmLNF5fHkSFkxw== Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 2EAA41EEF6; Thu, 11 Mar 2021 17:39:08 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 243C6188E7; Thu, 11 Mar 2021 17:39:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id XfOM5E2V7DgT; Thu, 11 Mar 2021 17:39:05 +0000 (UTC) To: John Baldwin , Mateusz Guzik , Kyle Evans DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com B81C3188DF Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202103091117.129BHOZa042851@gitrepo.freebsd.org> <8e37c710-bd9d-6fe0-0263-4efeabfd9beb@FreeBSD.org> From: Bryan Drewery Organization: FreeBSD Subject: Re: git: 1ae20f7c70ea - main - kern: malloc: fix panic on M_WAITOK during THREAD_NO_SLEEPING() Message-ID: <9132135e-8653-4df8-984e-c00806e4e533@FreeBSD.org> Date: Thu, 11 Mar 2021 09:39:04 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8e37c710-bd9d-6fe0-0263-4efeabfd9beb@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aVuFBlAJPYlT86BMcrZFhw1NvKwD0NTlj" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1615484348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hvpy29zrpEBk7JkeqnvMCTxdSrnsaJ21NlReM2R8SBE=; b=acBlAkl5tZr3AQyx9bjqT+MhILV78eiL3qT5aMqXZeZ/qFUeTFNX5alY8BUTI1ERARGdT8 eO0idBS/wReCNvEFAU47Oex9jNeo7254ccENZiC/xvrGu/RyoVYhK36RjVkLYeEvUQO73U OdrAYRpPOJatvHkiJAsTdAZfqPGTc3DqqfFxZJJ5x9QCBGwb16OKdFiA38GF1lCpErSC6X k6lhG8QFEP3LlpCtf/53QvwS+z2W7G06b9ldYsYbPhwvZW1oXuhnGEqUHzNaPOx796JNoc StXEbcO/vmSc1p26GQxMSDIEpFxdqZzBtIWLVB58c4cOxqSpDiXwK6FSFDkUSA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1615484348; a=rsa-sha256; cv=none; b=VIjrP1b0LZf2yMpumtUjXDdzrpYsugEhOgFfY/AsmGG49HYo8cOkPsXHj2j9oKl8FWTi3F ce52XsEsfJTGLkGQFJ5EqV3AiO6zcsDWY4U10rqjtrn9RhKvTvufqQRAOEoStwQQ1tkgjO WHXltyVfLdBc7hHtrJ8oDviig2izOQRv2SeNR+63T7EqzaHNCTuXvM9dyyBGnAGt4itbEV sI3S2pcDBUs8mJn+yaOJs5z9p4uIlRt1cB0LWcuqCQPnC72eFTM2czFgVUeFanNjSJ9KuD QtjeibASmonvF8wTo4s3CFM3vw1EkRkRmVTxFhu+w7te5gZgb8NTEffBzHIXwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 17:39:08 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aVuFBlAJPYlT86BMcrZFhw1NvKwD0NTlj Content-Type: multipart/mixed; boundary="o29koHnVcEqidntWU1GWZqJO9ROUgfbX6"; protected-headers="v1" From: Bryan Drewery To: John Baldwin , Mateusz Guzik , Kyle Evans Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-ID: <9132135e-8653-4df8-984e-c00806e4e533@FreeBSD.org> Subject: Re: git: 1ae20f7c70ea - main - kern: malloc: fix panic on M_WAITOK during THREAD_NO_SLEEPING() References: <202103091117.129BHOZa042851@gitrepo.freebsd.org> <8e37c710-bd9d-6fe0-0263-4efeabfd9beb@FreeBSD.org> In-Reply-To: <8e37c710-bd9d-6fe0-0263-4efeabfd9beb@FreeBSD.org> --o29koHnVcEqidntWU1GWZqJO9ROUgfbX6 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 3/11/2021 9:23 AM, John Baldwin wrote: > On 3/10/21 3:57 AM, Mateusz Guzik wrote: =2E.. > I don't know that we've had so many issues that we can't just fix them = on > HEAD right now vs having to make this a warning instead of keeping it a= s > a panic. >=20 Given this isn't a consistency assertion, a nice temporary mechanism would be to only warn during boot but panic for instances seen after that. Perhaps collecting and spamming the early warnings continually too so they get reported. Then less people are blocked from upgrading or having to deal with boot panics, and may be able to avoid triggering other cases. It's one thing to have INVARIANTS on HEAD and expect everyone to chip in on that, but another to have a prolonged unstable range of commits. just my 2 cents, Bryan --o29koHnVcEqidntWU1GWZqJO9ROUgfbX6-- --aVuFBlAJPYlT86BMcrZFhw1NvKwD0NTlj Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAmBKVbgFAwAAAAAACgkQNddxu25Gl8/r DQgAyXA6GZ/RjOKrEqcb0kSnMLzTdjws/55e+zpjgJTivXbcg4rHxDrsWBriqypHD3QlzaezitD/ uJuO8F5LZq7NizWQ6GaMfiq93L875OS75WtsZo701YDmxChhO4UAantRIS9/V0B1OHaDcKzHMCJy I73mhmYPYoeScTKBDH7Folj4Hvk4Y3o9AkefiAhDDfunIpnzE1tiY9KDgLxTB7edycIaom/FjBRV S10+JSAzB0SNihlPr3229EBh8rd9zK9QTlcKRGcMCM8Ksd8l7U/miAx1MZOGWHkZ/8vUjnSUtbeO PEADeI3nEKu5fmsiRCYlHk7xZJVutHlbx2vi0B1Axw== =Gs8d -----END PGP SIGNATURE----- --aVuFBlAJPYlT86BMcrZFhw1NvKwD0NTlj--