Date: Wed, 10 Aug 2016 20:11:20 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Emmanuel Vadot <manu@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r419993 - in head: mail/libmapi net/nanomsg Message-ID: <e5a63d61-887d-01cc-717b-58cfe7bb4dea@FreeBSD.org> In-Reply-To: <20160810115741.6a6433e66f20165df6e487a2@bidouilliste.com> References: <201608100821.u7A8LJqp055282@repo.freebsd.org> <fda2d72e-6032-241d-2d38-9039673653b4@FreeBSD.org> <EEE421018157A7D2D5A45576@atuin.in.mat.cc> <20160810115741.6a6433e66f20165df6e487a2@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/08/2016 7:57 PM, Emmanuel Vadot wrote:
> On Wed, 10 Aug 2016 11:03:22 +0200
> Mathieu Arnold <mat@FreeBSD.org> wrote:
>
>>
>>
>> +--On 10 août 2016 18:57:42 +1000 Kubilay Kocak <koobs@FreeBSD.org> wrote:
>> | On 10/08/2016 6:21 PM, Emmanuel Vadot wrote:
>> |> +.if ${PORT_OPTIONS:MDOCS}
>> |> +CMAKE_ARGS+= -DCMAKE_INSTALL_MANDIR:STRING=man
>> |> +.else
>> |> +CMAKE_ARGS+= -DNN_ENABLE_DOC=OFF
>> |> .endif
>> |
>> | This block can/should be replaced with options helpers (placed under
>> | DOCS_BUILD_DEPENDS):
>> |
>> | DOCS_CMAKE_BOOL= NN_ENABLE_DOC
>> | DOCS_CMAKE_ON= -DCMAKE_INSTALL_MANDIR:STRING=man
>> |
>> | See Mk/bsd.options.mk for details.
>>
>> Well, no, that should be, see the porter's handbook for details:
>> http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html
>
> I have this : https://people.freebsd.org/~manu/fix_nanomsg_doc.diff
>
> Everything is fine on the poudriere side (with and without DOCS option set)
> Do you guys want a new PR ?
>
No that's fine Emmanuel, just reference the original in the commit
message so it's logged there (as it's just a follow-up)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e5a63d61-887d-01cc-717b-58cfe7bb4dea>