From owner-cvs-src@FreeBSD.ORG Sun Oct 31 04:43:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C37516A4CF; Sun, 31 Oct 2004 04:43:24 +0000 (GMT) Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8816743D41; Sun, 31 Oct 2004 04:43:23 +0000 (GMT) (envelope-from gibbs@scsiguy.com) Received: from caspian.scsiguy.com (caspian.scsiguy.com [63.229.232.105]) by aslan.scsiguy.com (8.12.11/8.12.11) with ESMTP id i9V4hMYo044316; Sat, 30 Oct 2004 22:43:22 -0600 (MDT) (envelope-from gibbs@scsiguy.com) Date: Sat, 30 Oct 2004 22:44:36 -0700 From: "Justin T. Gibbs" To: Bruce M Simpson Message-ID: In-Reply-To: <20041031044021.GA2123@empiric.icir.org> References: <20041031035037.59607.qmail@web21422.mail.yahoo.com> <20041031044021.GA2123@empiric.icir.org> X-Mailer: Mulberry/3.1.6 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline cc: Matthew Jacob cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 04:43:24 -0000 > On Sat, Oct 30, 2004 at 10:35:58PM -0700, Justin T. Gibbs wrote: >> > Shouldn't an API for adding or removing ISR's be responsible for >> > handling just such a race condition? >> >> bus_teardown_intr() already has these semantics, but you have >> to know to use it and that it should only be called without >> locks held since it may sleep waiting for another CPU to >> leave your interrupt handler. > > Unfortunately I don't have a vr(4) card to test the changes with, and > it looks like the copy of if_vr.c in my local tree uses bus_teardown_intr() > correctly; these changes will have to be tested and committed after 5.3R. > > BMS You should be able to get rid of the suspended check in the isr too. -- Justin