From owner-freebsd-net@freebsd.org  Tue May 18 19:35:24 2021
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 42AA96556FA
 for <freebsd-net@mailman.nyi.freebsd.org>;
 Tue, 18 May 2021 19:35:24 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4Fl5nQ5j1fz4glH
 for <freebsd-net@freebsd.org>; Tue, 18 May 2021 19:35:22 +0000 (UTC)
 (envelope-from hps@selasky.org)
Received: from hps2020.home.selasky.org (unknown [178.17.145.105])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 38D42260111;
 Tue, 18 May 2021 21:35:20 +0200 (CEST)
Subject: Re: rip6_output not in net epoch across call to ip6_setpktopts()
To: Ryan Stone <rysto32@gmail.com>, freebsd-net <freebsd-net@freebsd.org>
References: <CAFMmRNziwec6GeuDvvhXzQE=z5boxXqT0pwDUu628dcYQWiKbQ@mail.gmail.com>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <f7234a05-c892-ea68-105f-78c6e1094650@selasky.org>
Date: Tue, 18 May 2021 21:34:03 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <CAFMmRNziwec6GeuDvvhXzQE=z5boxXqT0pwDUu628dcYQWiKbQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4Fl5nQ5j1fz4glH
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none;
 spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as
 permitted sender) smtp.mailfrom=hps@selasky.org
X-Spamd-Result: default: False [-0.69 / 15.00]; RCVD_TLS_ALL(0.00)[];
 RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[];
 FROM_HAS_DN(0.00)[];
 RBL_DBL_DONT_QUERY_IPS(0.00)[88.99.82.50:from];
 R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net];
 MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org];
 ARC_NA(0.00)[];
 SPAMHAUS_ZRD(0.00)[88.99.82.50:from:127.0.2.255];
 TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[];
 NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2];
 NEURAL_SPAM_LONG(1.00)[0.998];
 NEURAL_HAM_MEDIUM(-0.39)[-0.385];
 FREEMAIL_TO(0.00)[gmail.com,freebsd.org];
 FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[];
 MIME_TRACE(0.00)[0:+];
 ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE];
 RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-net]
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 May 2021 19:35:24 -0000

On 5/18/21 9:18 PM, Ryan Stone wrote:
> The issue seems to be that rip6_output() calls into ip6_setpktopts()
> outside of the net epoch.  Should I just wrap the setpktopts call in a
> net epoch enter/exit, or does anybody think that there's something
> cleverer that should be done there?

Hi,

Epoch automagically detects recursion, and optimizes for that. If there 
is an inner section of enter/exit, covered by an outer section, the 
overhead will be less for the inner section.

--HPS