From owner-svn-ports-all@freebsd.org  Thu Sep  7 12:17:04 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7788CE1BB00;
 Thu,  7 Sep 2017 12:17:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 50D7B84AC0;
 Thu,  7 Sep 2017 12:17:03 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 33663C6D7; Thu,  7 Sep 2017 12:16:34 +0000 (UTC)
Date: Thu, 7 Sep 2017 12:16:34 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Christian Weisgerber <naddy@mips.inka.de>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r449357 - in head/net-p2p/mktorrent: . files
Message-ID: <20170907121634.GA36955@FreeBSD.org>
References: <201709061910.v86JA8Rd002544@repo.freebsd.org>
 <20170907093407.GA7480@FreeBSD.org>
 <20170907120434.GA25166@lorvorc.mips.inka.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170907120434.GA25166@lorvorc.mips.inka.de>
User-Agent: Mutt/1.8.3 (2017-05-23)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Sep 2017 12:17:04 -0000

On Thu, Sep 07, 2017 at 02:04:34PM +0200, Christian Weisgerber wrote:
> Alexey Dokuchaev:
> > > ...
> > > -MASTER_SITES=	SF
> > > +MASTER_SITES=	https://github.com/Rudde/mktorrent/archive/
> > > +DISTNAME=	v${PORTVERSION}
> > > +DIST_SUBDIR=	${PORTNAME}
> > 
> > Why not use USE_GITHUB and avoid having to set MASTER_SITES and all these
> > DIST_SUBDIR dances?
> 
> I don't know which scheme is preferable.  The Porter's Handbook
> section on USE_GITHUB starts with "If the distribution file comes
> from a specific commit or tag on GitHub for which there is no
> officially released file, [...]".  But here we have an officially
> released if awkwardly named distfile.

It was fixed by mat@ (I guess he got tired of trying to teach people and
just silently cleans up after them now).

I suggest you follow other people commits in addition to reading the PHB,
it'll give you ideas and examples of the most common/current practices.

./danfe