From owner-freebsd-stable Sun Jul 23 15:59:22 2000 Delivered-To: freebsd-stable@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 680E637C329 for ; Sun, 23 Jul 2000 15:59:14 -0700 (PDT) (envelope-from jhb@pike.osd.bsdi.com) Received: (from jhb@localhost) by pike.osd.bsdi.com (8.9.3/8.9.3) id PAA25754; Sun, 23 Jul 2000 15:58:53 -0700 (PDT) (envelope-from jhb) From: John Baldwin Message-Id: <200007232258.PAA25754@pike.osd.bsdi.com> Subject: Re: sysinstall resetting USA_RESIDENT=NO In-Reply-To: from Tim Zingelman at "Jul 23, 2000 05:49:57 pm" To: Tim Zingelman Date: Sun, 23 Jul 2000 15:58:53 -0700 (PDT) Cc: stable@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL68 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Tim Zingelman wrote: > On Sun, 23 Jul 2000, John Baldwin wrote: > > No, he's right. sysinstall is definitely broken in this respect, and > > I'm definitely interested in your patches to fix it. :) > > The patches are attached... > > In either the case that no make.conf exists, or one exists without a > USA_RESIDENT line in it, the line is added, regardless of if I have > confirmed that the default NO is correct or not. Hmm, we probably shouldn't do this. I think your first patchset is actually the proper one. Ultimately, the user needs to choose whether or not they are in the U.S., we should never choose this for them. Thus, we should only write anything out if we ask them the question. > In the case that make.conf has a USA_RESIDENT line, I only overwrite that > line if the user has answered the question 'are you really a us resident'. Yes, this is good. :) > Let me know if you have any questions. Thanks. > > - Tim -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.cslab.vt.edu/~jobaldwi/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message