Date: 19 Apr 2002 01:03:07 +0200 From: Dag-Erling Smorgrav <des@ofug.org> To: Warner Losh <imp@harmony.village.org> Cc: Jeroen Ruigrok/asmodai <asmodai@wxs.nl>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libypclnt Makefile Message-ID: <xzphem88v9w.fsf@flood.ping.uio.no> In-Reply-To: <200204182117.g3ILHIx08776@harmony.village.org> References: <20020418192213.GW24261@daemon.ninth-circle.org> <200204181620.g3IGKIu51885@freefall.freebsd.org> <200204182117.g3ILHIx08776@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@harmony.village.org> writes: > Yes. I think that the 1.8 style (david's) matches how the rest of the > tree is done better than the 1.9 style (des's). I see no point to the > sill backout and wish that Des and David could get along better. The problem (as I see it) is that David was making these commits not for technical reasons, but to prove some kind of superiority or authority over me (even if he is not fully aware of it himself). There was absolutely no overriding technical reason to rush this commit. To add insult to injury, he did send out a "heads-up" about the commit, but half an hour *after* the fact. I replied, thinking he expected feedback, and offered a compromise solution. When I discovered that he had already made the commit, however, I took it as a clear indication that he was not interested in anything I have to say about the matter, but only in "being right" or "winning". My intent with backing out his commit was to bring us back to square one so we could discuss this properly before deciding on a solution. David claims that listing multiple files on a single line does not adversely affect the readability of the Makefile (which is debatable) nor of diffs that add or remove files (which is not). I switched to the style I currently use (which is based on the style used in the ports tree) after one too many merge conflicts caused by listing multiple files on a single line, mainly in /sys/modules, where the dominant style is now to lists each subdirectory or file on a separate line. David apparently objected to my use of +=, which I can live without (as he would have found out if he had sought my opinion before committing). > Also, it has been pretty much universally agreed that we have no > strong maintainers anymore, so standing on those grounds to back out > the change, also without talking about it, is pretty flimsy at best. Do you deny that libypclnt is a work in progress? Do you deny that the rule for patches to WIPs is "submit them to whoever is currently working on it"? DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzphem88v9w.fsf>