From owner-freebsd-net@freebsd.org  Mon Apr 18 01:39:14 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A859AB117B1
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Mon, 18 Apr 2016 01:39:14 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org
 [IPv6:2610:1c1:1:607c::16:b])
 by mx1.freebsd.org (Postfix) with ESMTP id 81C7A1AD4
 for <freebsd-net@freebsd.org>; Mon, 18 Apr 2016 01:39:14 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346)
 id 7D206CD58; Mon, 18 Apr 2016 01:39:13 +0000 (UTC)
Date: Mon, 18 Apr 2016 01:39:13 +0000
To: freebsd-net@freebsd.org
From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org>
Reply-to: D5872+325+9dea0574509cdbb3@reviews.freebsd.org
Subject: [Differential] [Commented On] D5872: tcp: Don't prematurely drop
 receiving-only connections
Message-ID: <b360b492b58acf738885c49eea271ff9@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
Thread-Topic: D5872: tcp: Don't prematurely drop receiving-only connections
X-Herald-Rules: <64>
X-Phabricator-To: <PHID-USER-owbigh336siepsaab2ye>
X-Phabricator-To: <PHID-PROJ-62ihepuxzgyzg7rh5uic>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-s22ldiy33wseno7vfmzs>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-n3y55yy4j7xarsdk3otz>
X-Phabricator-To: <PHID-USER-aojo5yplx3m2nkpgwndr>
X-Phabricator-To: <PHID-USER-57eqaez2c2qhlyhs4xoi>
X-Phabricator-To: <PHID-USER-4lzxzqflpaankb5hk2y4>
X-Phabricator-To: <PHID-USER-dyyyzfp34mimhzvg33tk>
X-Phabricator-To: <PHID-PROJ-u7z45dkhkb4gc5luse77>
X-Phabricator-To: <PHID-USER-qmfo4xh7l6f2cud3zfo7>
X-Phabricator-To: <PHID-USER-hh4avozwa3ssphnwhjxx>
X-Phabricator-Cc: <PHID-USER-x2wszzhtr5egla5eo3md>
X-Phabricator-Cc: <PHID-USER-qmfo4xh7l6f2cud3zfo7>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
Thread-Index: MmVmNzYzNzljOGQxMmM4MWI4MmNjYzcxMzczIFcUOsE=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.21
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Apr 2016 01:39:14 -0000

sepherosa_gmail.com added a comment.


  In https://reviews.freebsd.org/D5872#127372, @mike-karels.net wrote:
  
  > Setting a retransmission timer on an ACK makes no sense; I don't think tcp_output will send an ACK on a retransmission timeout.
  >
  > Setting timers in the ENOBUFS case is at best a partial fix.  If the ACK is lost locally, we know; if it is lost elsewhere, we don't. We need timers in any case.
  >
  > Setting  a local timer for the ACK case is no better for latency than having the other end run a retransmit timer..
  >
  > If there is a problem with setting the retransmit timer for a FIN, let's fix that.  Otherwise, I stand by my recommendation of deleting the code to set a timer.
  
  
  Yeah, delete the retransmission timeout is fine w/ me.  Do we reach consensus here?

REVISION DETAIL
  https://reviews.freebsd.org/D5872

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, glebius, lstewart, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, freebsd-net-list, transport, jtl, hiren
Cc: mike-karels.net, jtl