From owner-svn-ports-all@FreeBSD.ORG Mon Dec 2 22:33:50 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B99D7DAE; Mon, 2 Dec 2013 22:33:50 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7AB411104; Mon, 2 Dec 2013 22:33:50 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 7D4B2BDC69; Mon, 2 Dec 2013 23:33:46 +0100 (CET) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id 6B47BBDC44; Mon, 2 Dec 2013 23:33:46 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id 8E7C6C90B4B3; Mon, 2 Dec 2013 23:33:43 +0100 (CET) Date: Mon, 02 Dec 2013 23:33:41 +0100 From: Mathieu Arnold To: "Sergey A. Osokin" , Mathieu Arnold Subject: Re: svn commit: r335523 - in head/www/nginx: . files Message-ID: <58E1447598180A2EFC0BC448@atuin.in.mat.cc> In-Reply-To: <20131202191057.GB93494@FreeBSD.org> References: <201312021814.rB2IEKZc015166@svn.freebsd.org> <20131202191057.GB93494@FreeBSD.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 22:33:50 -0000 Hi, +--On 2 d=C3=A9cembre 2013 19:10:57 +0000 "Sergey A. Osokin" = wrote: | Please revert back these wrong changes ASAP. The PR has been sitting for four and a half months. If it is wrong, you should have said something there, so, what exactly is wrong with them ? Regards, | On Mon, Dec 02, 2013 at 06:14:20PM +0000, Mathieu Arnold wrote: |> Author: mat |> Date: Mon Dec 2 18:14:19 2013 |> New Revision: 335523 |> URL: http://svnweb.freebsd.org/changeset/ports/335523 |>=20 |> Log: |> The patch for adding syslog support sets the wrong define variable |> causing syslog support to not be built. |> =20 |> maintainer timeout. |> =20 |> PR: ports/180639 |> Submitted by: Dave Duchscher |>=20 |> Modified: |> head/www/nginx/Makefile |> head/www/nginx/files/extra-patch-syslog_support |>=20 |> Modified: head/www/nginx/Makefile |> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D |> =3D=3D=3D=3D=3D=3D --- head/www/nginx/Makefile Mon Dec 2 18:08:41 = 2013 (r335522) |> +++ head/www/nginx/Makefile Mon Dec 2 18:14:19 2013 (r335523) |> @@ -3,6 +3,7 @@ |> =20 |> PORTNAME=3D nginx |> PORTVERSION=3D 1.4.4 |> +PORTREVISION=3D 1 |> PORTEPOCH=3D 1 |> CATEGORIES=3D www |> MASTER_SITES=3D http://nginx.org/download/ |>=20 |> Modified: head/www/nginx/files/extra-patch-syslog_support |> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D |> =3D=3D=3D=3D=3D=3D --- = head/www/nginx/files/extra-patch-syslog_support Mon Dec 2 |> 18:08:41 2013 (r335522) +++ |> head/www/nginx/files/extra-patch-syslog_support Mon Dec 2 18:14:19 2013 |> (r335523) @@ -721,7 +721,7 @@ index 54e1c26..2b05157 100644 |> + SYSLOG_FACILITY=3D"LOG_DAEMON" |> +fi |> +if test "${USE_SYSLOG}" =3D "YES"; then |> -+ CFLAGS=3D"$CFLAGS -DUSE_SYSLOG = -DSYSLOG_FACILITY=3D${SYSLOG_FACILITY}" |> ++ CFLAGS=3D"$CFLAGS -DNGX_ENABLE_SYSLOG |> -DSYSLOG_FACILITY=3D${SYSLOG_FACILITY}" +fi |> =20 |> cat << END > |> $NGX_MAKEFILE |=20 --=20 Mathieu Arnold